OpenWF/SpaceNinjaServer
16
14
Fork 17
Code Issues 38 Pull Requests 2 Actions Packages Projects Releases Activity

Handle adding booster in addItem #2146

Closed
nyaoouo wants to merge 1 commits from nyaoouo:Handle-booser-in-addItem into main
pull from: nyaoouo:Handle-booser-in-addItem
merge into: OpenWF:main
Conversation 4 Commits 1 Files Changed 1 +24 -7
nyaoouo commented 2025-06-11 00:43:59 -07:00
Contributor
Copy Link

would raise error when handling RadioLegionIntermission2Syndicate Level 14

"reward": {
    "ItemCount": 1,
    "ItemType": "/Lotus/Types/Boosters/AffinityBooster"
}
would raise error when handling RadioLegionIntermission2Syndicate Level 14 ``` "reward": { "ItemCount": 1, "ItemType": "/Lotus/Types/Boosters/AffinityBooster" } ```
nyaoouo added 1 commit 2025-06-11 00:43:59 -07:00
Handle adding booster in addItem
All checks were successful
Build / build (pull_request) Successful in 1m13s
Details
4910de959a
Sainan commented 2025-06-11 02:35:30 -07:00
Owner
Copy Link
- It's a 3 day booster: <https://www.reddit.com/r/Warframe/comments/duqktj/comment/f77ozsn> - You didn't have to rewrite addBooster for this.
Sainan closed this pull request 2025-06-11 02:42:08 -07:00
nyaoouo commented 2025-06-11 02:46:25 -07:00
Author
Contributor
Copy Link
> - It's a 3 day booster: <https://www.reddit.com/r/Warframe/comments/duqktj/comment/f77ozsn> > - You didn't have to rewrite addBooster for this. I'm not sure anywhere might need to provide the InventoryChange return when adding Boosters, maybe it would be better to implement it first?
nyaoouo commented 2025-06-11 02:47:56 -07:00
Author
Contributor
Copy Link

so each quantity cast as three days or hard code it will be better?

> - It's a 3 day booster: <https://www.reddit.com/r/Warframe/comments/duqktj/comment/f77ozsn> > - You didn't have to rewrite addBooster for this. so each quantity cast as three days or hard code it will be better?
Sainan commented 2025-06-11 02:48:54 -07:00
Owner
Copy Link

Next time just open an issue to report a bug. :)

Next time just open an issue to report a bug. :)
All checks were successful
Build / build (pull_request) Successful in 1m13s
Details

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
An existing implemention is incorrect
dependencies
Pull requests that update a dependency file
documentation
Improvements or additions to documentation
enhancement
New feature or request specific to the emulator
help wanted
Extra attention is needed
improvement
missing data
part of more major rehaul
Can't be worked on right now without merge conflicts later
pr'd for
Soon™
question
Further information is requested
unimplemented
you can do this
Considered easy enough for someone's first PR.
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: OpenWF/SpaceNinjaServer#2146
No description provided.
Delete Branch "nyaoouo:Handle-booser-in-addItem"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?