If the configs in config.json are set to true, they override everything but they don't actually modify the inventory database which causes issues like incomplete quests despite the inventory database having complete quests #210

New Issue

Sainan · 2024-05-09T10:04:03-07:00

RubynRuby commented

2024-05-09 10:04:03 -07:00

(Migrated from github.com)

instead of overriding everything all the time, its better to make the config add things/merge things into the inventory database and then automatically turn to false to avoid such issues

Let's say for example, i have unlock all missions and unlock all quests as true

the star chart will be unlocked, the quest will be unlocked but not completed

even if the player has a correct and complete quest keys entry in their inventory database

unlock all quests has to be set to false in order for the game to recognize the inventory database quest keys section

if unlock all missions is set to false, the star chart will get locked again

So, no actual modification occurs in the inventory database, it just overrides things.

In my opinion, it should merge/add the missions and quests into the inventory database

most likely, the other settings suffer the same issue, not just missions and quests

instead of overriding everything all the time, its better to make the config add things/merge things into the inventory database and then automatically turn to false to avoid such issues ![image](https://github.com/spaceninjaserver/SpaceNinjaServer/assets/158524595/26e62f3f-b33e-4d88-b422-bf63cc89d6ec) Let's say for example, i have unlock all missions and unlock all quests as true the star chart will be unlocked, the quest will be unlocked but not completed even if the player has a correct and complete quest keys entry in their inventory database unlock all quests has to be set to false in order for the game to recognize the inventory database quest keys section if unlock all missions is set to false, the star chart will get locked again So, no actual modification occurs in the inventory database, it just overrides things. In my opinion, it should merge/add the missions and quests into the inventory database most likely, the other settings suffer the same issue, not just missions and quests

Sainan commented

2024-05-09 10:07:10 -07:00

The behaviour of the config itself is fine and as expected. unlockAllQuests specifically could handle you already having completed certain quests a bit better, tho.

The behaviour of the config itself is fine and as expected. `unlockAllQuests` specifically could handle you already having completed certain quests a bit better, tho.

❤️ 1

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: OpenWF/SpaceNinjaServer#210