OpenWF/SpaceNinjaServer
21
23
Fork 24
Code Issues 24 Pull Requests 4 Actions Packages Projects Releases Activity

WIP: feat(webui): Themes dropdown menu #2093

Closed
Animan8000 wants to merge 13 commits from Animan8000/SpaceNinjaServer:theme into main
pull from: Animan8000/SpaceNinjaServer:theme
merge into: OpenWF:main
Conversation 5 Commits 13 Files Changed 8 +35 -2
Animan8000 commented 2025-05-21 09:58:45 -07:00
Contributor
Copy Link

Gives people the ability to switch to white (light) theme, if they want to. Dark is used by default. Initially wanted to add system-aware but realized how pointless that is, if almost everyone wants Dark as default anyway, realistically.

Gives people the ability to switch to white (light) theme, if they want to. Dark is used by default. Initially wanted to add system-aware but realized how pointless that is, if almost everyone wants Dark as default anyway, realistically.
Animan8000 added 12 commits 2025-05-21 09:58:45 -07:00
Update static/webui/script.js
All checks were successful
Build / build (pull_request) Successful in 51s
Details
437b81e522
Sainan commented 2025-05-21 10:26:17 -07:00
Owner
Copy Link

Not insanely mobile friendly

image.png

Not insanely mobile friendly ![image.png](/attachments/0c19a2b1-58a9-48ff-95eb-9f8fd46be791)
image.png
12 KiB
Animan8000 commented 2025-05-21 10:46:21 -07:00
Author
Contributor
Copy Link

I see what you mean, mhm. But still usable enough, no? I tried changing to "Dark" & "Light" in the strings, but even on "Light" it already starts to insert the additional space. Not like a person would use the WebUI with such limited space likely anyway (even then, this doesn't limit the functionality from what I can tell, the extra space)

I see what you mean, mhm. But still usable enough, no? I tried changing to "Dark" & "Light" in the strings, but even on "Light" it already starts to insert the additional space. Not like a person would use the WebUI with such limited space likely anyway (even then, this **doesn't** limit the functionality from what I can tell, the extra space)
Animan8000 commented 2025-05-22 03:16:44 -07:00
Author
Contributor
Copy Link

Let me know if I should change this in a "particular way". Been experimenting a bit with some ideas but havent found something that works ideal yet...

Let me know if I should change this in a "particular way". Been experimenting a bit with some ideas but havent found something that works ideal yet...
Sainan commented 2025-05-22 03:20:39 -07:00
Owner
Copy Link

I don't see who this feature is for. It's a fine implementation, but I don't see the absurd amount of space this takes remotely being worth it given that I estimate literally no one will use it.

I don't see who this feature is for. It's a fine implementation, but I don't see the absurd amount of space this takes remotely being worth it given that I estimate literally no one will use it.
Sainan changed title from feat(webui): Themes dropdown menu to WIP: feat(webui): Themes dropdown menu 2025-05-23 06:06:46 -07:00
Animan8000 commented 2025-05-23 09:32:06 -07:00
Author
Contributor
Copy Link

Let me know if I should change this in a "particular way". Been experimenting a bit with some ideas but havent found something that works ideal yet...

I've been actually thinking of adding a gear icon, that shows these things when clicking on it (when window is really small), but so far its been more headache than it needs to be (I already hate html now)

> Let me know if I should change this in a "particular way". Been experimenting a bit with some ideas but havent found something that works ideal yet... I've been actually thinking of adding a gear icon, that shows these things when clicking on it (when window is really small), but so far its been more headache than it needs to be (I already hate html now)
Animan8000 added 1 commit 2025-06-08 09:45:41 -07:00
merge upstream
All checks were successful
Build / build (pull_request) Successful in 2m4s
Details
2bf6e5cd80
Sainan closed this pull request 2025-06-29 09:08:05 -07:00
All checks were successful
Build / build (pull_request) Successful in 2m4s
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
An existing implemention is incorrect
dependencies
Pull requests that update a dependency file
documentation
Improvements or additions to documentation
enhancement
New feature or request specific to the emulator
help wanted
Extra attention is needed
improvement
missing data
part of more major rehaul
Can't be worked on right now without merge conflicts later
pr'd for
Soon™
question
Further information is requested
unimplemented
you can do this
Considered easy enough for someone's first PR.
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: OpenWF/SpaceNinjaServer#2093
No description provided.
Delete Branch "Animan8000/SpaceNinjaServer:theme"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?