OpenWF/SpaceNinjaServer
12
6
Fork 14
Code Issues 42 Pull Requests Actions Packages Projects Releases Activity

feat: implement loading of ability videos #205

Merged
Sainan merged 2 commits from ability-videos into main 2024-05-29 16:44:54 -07:00
Conversation 5 Commits 2 Files Changed 1 +17
Sainan commented 2024-05-08 15:29:04 -07:00
Owner
Copy Link
No description provided.
OrdisPrime (Migrated from github.com) reviewed 2024-05-08 15:50:11 -07:00
src/routes/cache.ts
OrdisPrime (Migrated from github.com) commented 2024-05-08 15:50:04 -07:00
Author
Owner
Copy Link

wouldn't readFile be better as it is non-blocking? same for the other Sync?

wouldn't readFile be better as it is non-blocking? same for the other Sync?
Sainan reviewed 2024-05-08 15:51:10 -07:00
src/routes/cache.ts
Sainan commented 2024-05-08 15:51:10 -07:00
Author
Owner
Copy Link

You would know that better than me. From what I understand, JavaScript is single-threaded either way.

You would know that better than me. From what I understand, JavaScript is single-threaded either way.
OrdisPrime (Migrated from github.com) reviewed 2024-05-08 16:10:43 -07:00
src/routes/cache.ts
OrdisPrime (Migrated from github.com) commented 2024-05-08 16:10:43 -07:00
Author
Owner
Copy Link

based on my experience using non-sync methods is always better.
Yes, js is single-threaded however the whole server blocks while using a sync method, so lets use the non-sync ones here.

based on my experience using non-sync methods is always better. Yes, js is single-threaded however the whole server blocks while using a sync method, so lets use the non-sync ones here.
Sainan reviewed 2024-05-08 16:14:19 -07:00
src/routes/cache.ts
Sainan commented 2024-05-08 16:14:19 -07:00
Author
Owner
Copy Link

I'm afraid I'm not sure how to elegantly write this code to be async. Plus, I'm not sure the overhead of reading from a modern disk is that significant. Might be worse we were dealing with multiple clients. I would use express' sendFile, but it errors due to the weird paths.

I'm afraid I'm not sure how to elegantly write this code to be async. Plus, I'm not sure the overhead of reading from a modern disk is that significant. Might be worse we were dealing with multiple clients. I would use express' sendFile, but it errors due to the weird paths.
OrdisPrime (Migrated from github.com) reviewed 2024-05-08 18:00:12 -07:00
src/routes/cache.ts
OrdisPrime (Migrated from github.com) commented 2024-05-08 18:00:12 -07:00
Author
Owner
Copy Link

ill check tomorrow!

ill check tomorrow!
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
An existing implemention is incorrect
dependencies
Pull requests that update a dependency file
documentation
Improvements or additions to documentation
enhancement
New feature or request specific to the emulator
help wanted
Extra attention is needed
improvement
missing data
part of more major rehaul
Can't be worked on right now without merge conflicts later
pr'd for
Soon™
question
Further information is requested
unimplemented
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: OpenWF/SpaceNinjaServer#205
No description provided.
Delete Branch "ability-videos"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?