OpenWF/SpaceNinjaServer
12
6
Fork 14
Code Issues 50 Pull Requests 8 Actions Packages Projects Releases Activity

chore: remove query for ship in getShipController #2022

Merged
Sainan merged 1 commits from simplify-get-ship into main 2025-05-08 17:37:01 -07:00
Conversation 1 Commits 1 Files Changed 1 +2 -4
Sainan commented 2025-05-08 04:56:41 -07:00
Owner
Copy Link

as far as I can tell, the ShipAttachments and SkinFlavourItem are just here due to the fact that the type from ShipExterior is being reused, but they aren't actually needed because the interior can't have attachments or flavour items - and if it could, they would be different from the exterior anyway.

as far as I can tell, the ShipAttachments and SkinFlavourItem are just here due to the fact that the type from ShipExterior is being reused, but they aren't actually needed because the interior can't have attachments or flavour items - and if it could, they would be different from the exterior anyway.
Sainan added 1 commit 2025-05-08 04:56:41 -07:00
chore: remove query for ship in getShipController
All checks were successful
Build / build (pull_request) Successful in 1m40s
Details
Build / build (push) Successful in 1m50s
Details
ceaa172675 
as far as I can tell, the ShipAttachments and SkinFlavourItem are just here due to the fact that the type from ShipExterior is being reused, but they aren't actually needed because the interior can't have attachments or flavour items - and if it could, they would be different from the exterior anyway.
OrdisPrime commented 2025-05-08 08:20:09 -07:00
Owner
Copy Link

Initially I did it to mimick the original getShip response, perhaps you can compare if it still matches the original response.
I did not just add it because of some type requirement or so, it had a functional or structural reason (matching original getship).
If all works anway, sure, nice.

Initially I did it to mimick the original getShip response, perhaps you can compare if it still matches the original response. I did not just add it because of some type requirement or so, it had a functional or structural reason (matching original getship). If all works anway, sure, nice.
Sainan merged commit 8d788d38a5 into main 2025-05-08 17:37:01 -07:00
Sainan deleted branch simplify-get-ship 2025-05-08 17:37:01 -07:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
An existing implemention is incorrect
dependencies
Pull requests that update a dependency file
documentation
Improvements or additions to documentation
enhancement
New feature or request specific to the emulator
help wanted
Extra attention is needed
improvement
missing data
part of more major rehaul
Can't be worked on right now without merge conflicts later
pr'd for
Soon™
question
Further information is requested
unimplemented
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: OpenWF/SpaceNinjaServer#2022
No description provided.
Delete Branch "simplify-get-ship"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?