OpenWF/SpaceNinjaServer
12
6
Fork 14
Code Issues 42 Pull Requests Actions Packages Projects Releases Activity

Error with Profit-Taker Heist Stage 1 #1964

New Issue
Closed
opened 2025-05-02 14:00:14 -07:00 by VampireKitten · 2 comments
VampireKitten commented 2025-05-02 14:00:14 -07:00
Contributor
Copy Link

I... don't believe it's supposed to return NaN rotations?

2025-05-02T22:58:42:879 [0.1.0] debug:  generating random mission rewards {
  rewardManifests: [
    '/Lotus/Types/Game/MissionDecks/HeistJobMissionRewards/HeistTierATableARewards'
  ],
  rotations: [ NaN ]
}
2025-05-02T22:58:42:881 [0.1.0] error:  TypeError: Cannot read properties of undefined (reading 'length') while processing /api/missionInventoryUpdate.php request
    at getRewardAtPercentage (C:\Games\Warframe - Server Emulator\SpaceNinjaServer\src\services\rngService.ts:25:14)
    at SRng.randomReward (C:\Games\Warframe - Server Emulator\SpaceNinjaServer\src\services\rngService.ts:158:37)
    at getRandomRewardByChance (C:\Games\Warframe - Server Emulator\SpaceNinjaServer\src\services\missionInventoryUpdateService.ts:107:25)
    at <anonymous> (C:\Games\Warframe - Server Emulator\SpaceNinjaServer\src\services\missionInventoryUpdateService.ts:1535:34)
    at Array.forEach (<anonymous>)
    at getRandomMissionDrops (C:\Games\Warframe - Server Emulator\SpaceNinjaServer\src\services\missionInventoryUpdateService.ts:1525:25)
    at addMissionRewards (C:\Games\Warframe - Server Emulator\SpaceNinjaServer\src\services\missionInventoryUpdateService.ts:842:46)
    at missionInventoryUpdateController (C:\Games\Warframe - Server Emulator\SpaceNinjaServer\src\controllers\api\missionInventoryUpdateController.ts:83:32)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
2025-05-02T22:58:42:883 [0.1.0] http:   POST /api/missionInventoryUpdate.php?accountId=67bcb55f31fac393062d59a0&nonce=7206727101922283&ct=MSI&xpBasedLevelCapDisabled=1 500 77.121 ms - -
I... don't believe it's supposed to return NaN rotations? ``` 2025-05-02T22:58:42:879 [0.1.0] debug: generating random mission rewards { rewardManifests: [ '/Lotus/Types/Game/MissionDecks/HeistJobMissionRewards/HeistTierATableARewards' ], rotations: [ NaN ] } 2025-05-02T22:58:42:881 [0.1.0] error: TypeError: Cannot read properties of undefined (reading 'length') while processing /api/missionInventoryUpdate.php request at getRewardAtPercentage (C:\Games\Warframe - Server Emulator\SpaceNinjaServer\src\services\rngService.ts:25:14) at SRng.randomReward (C:\Games\Warframe - Server Emulator\SpaceNinjaServer\src\services\rngService.ts:158:37) at getRandomRewardByChance (C:\Games\Warframe - Server Emulator\SpaceNinjaServer\src\services\missionInventoryUpdateService.ts:107:25) at <anonymous> (C:\Games\Warframe - Server Emulator\SpaceNinjaServer\src\services\missionInventoryUpdateService.ts:1535:34) at Array.forEach (<anonymous>) at getRandomMissionDrops (C:\Games\Warframe - Server Emulator\SpaceNinjaServer\src\services\missionInventoryUpdateService.ts:1525:25) at addMissionRewards (C:\Games\Warframe - Server Emulator\SpaceNinjaServer\src\services\missionInventoryUpdateService.ts:842:46) at missionInventoryUpdateController (C:\Games\Warframe - Server Emulator\SpaceNinjaServer\src\controllers\api\missionInventoryUpdateController.ts:83:32) at process.processTicksAndRejections (node:internal/process/task_queues:95:5) 2025-05-02T22:58:42:883 [0.1.0] http: POST /api/missionInventoryUpdate.php?accountId=67bcb55f31fac393062d59a0&nonce=7206727101922283&ct=MSI&xpBasedLevelCapDisabled=1 500 77.121 ms - - ```
Sainan added the
bug
 label 2025-05-02 15:07:31 -07:00
Sainan added the
pr'd for
 label 2025-05-02 17:49:42 -07:00
VampireKitten commented 2025-05-04 09:07:59 -07:00
Author
Contributor
Copy Link

Reopening this issue because the previous fix has created an entirely different problem.

2025-05-04T18:07:45:896 [0.1.0] debug:  generating random mission rewards {
  rewardManifests: [
    '/Lotus/Types/Game/MissionDecks/HeistJobMissionRewards/HeistTierATableARewards'
  ],
  rotations: [ 2 ]
}
2025-05-04T18:07:45:897 [0.1.0] error:  TypeError: Cannot read properties of undefined (reading 'length') while processing /api/missionInventoryUpdate.php request
    at getRewardAtPercentage (C:\Games\Warframe - Server Emulator\SpaceNinjaServer\src\services\rngService.ts:25:14)
    at SRng.randomReward (C:\Games\Warframe - Server Emulator\SpaceNinjaServer\src\services\rngService.ts:158:37)
    at getRandomRewardByChance (C:\Games\Warframe - Server Emulator\SpaceNinjaServer\src\services\missionInventoryUpdateService.ts:107:25)
    at <anonymous> (C:\Games\Warframe - Server Emulator\SpaceNinjaServer\src\services\missionInventoryUpdateService.ts:1539:34)
    at Array.forEach (<anonymous>)
    at getRandomMissionDrops (C:\Games\Warframe - Server Emulator\SpaceNinjaServer\src\services\missionInventoryUpdateService.ts:1529:25)
    at addMissionRewards (C:\Games\Warframe - Server Emulator\SpaceNinjaServer\src\services\missionInventoryUpdateService.ts:842:46)
    at missionInventoryUpdateController (C:\Games\Warframe - Server Emulator\SpaceNinjaServer\src\controllers\api\missionInventoryUpdateController.ts:85:32)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
2025-05-04T18:07:45:899 [0.1.0] http:   POST /api/missionInventoryUpdate.php?accountId=67bcb55f31fac393062d59a0&nonce=1339495154560886&ct=MSI&xpBasedLevelCapDisabled=1 500 73.617 ms - -
Reopening this issue because the previous fix has created an entirely *different* problem. ``` 2025-05-04T18:07:45:896 [0.1.0] debug: generating random mission rewards { rewardManifests: [ '/Lotus/Types/Game/MissionDecks/HeistJobMissionRewards/HeistTierATableARewards' ], rotations: [ 2 ] } 2025-05-04T18:07:45:897 [0.1.0] error: TypeError: Cannot read properties of undefined (reading 'length') while processing /api/missionInventoryUpdate.php request at getRewardAtPercentage (C:\Games\Warframe - Server Emulator\SpaceNinjaServer\src\services\rngService.ts:25:14) at SRng.randomReward (C:\Games\Warframe - Server Emulator\SpaceNinjaServer\src\services\rngService.ts:158:37) at getRandomRewardByChance (C:\Games\Warframe - Server Emulator\SpaceNinjaServer\src\services\missionInventoryUpdateService.ts:107:25) at <anonymous> (C:\Games\Warframe - Server Emulator\SpaceNinjaServer\src\services\missionInventoryUpdateService.ts:1539:34) at Array.forEach (<anonymous>) at getRandomMissionDrops (C:\Games\Warframe - Server Emulator\SpaceNinjaServer\src\services\missionInventoryUpdateService.ts:1529:25) at addMissionRewards (C:\Games\Warframe - Server Emulator\SpaceNinjaServer\src\services\missionInventoryUpdateService.ts:842:46) at missionInventoryUpdateController (C:\Games\Warframe - Server Emulator\SpaceNinjaServer\src\controllers\api\missionInventoryUpdateController.ts:85:32) at process.processTicksAndRejections (node:internal/process/task_queues:95:5) 2025-05-04T18:07:45:899 [0.1.0] http: POST /api/missionInventoryUpdate.php?accountId=67bcb55f31fac393062d59a0&nonce=1339495154560886&ct=MSI&xpBasedLevelCapDisabled=1 500 73.617 ms - - ```
VampireKitten commented 2025-05-04 09:12:43 -07:00
Author
Contributor
Copy Link

Given this code, I presume the issue is that we're passing the job stage as the rotation, but the profit-taker heists only give rewards at the end of the bounty, so they have only one reward table per bounty with one rotation, leading to the error.

                        if (job.xpAmounts.length > 1) {
                            rotations = [RewardInfo.JobStage! % (job.xpAmounts.length - 1)];
                        } else {
                            rotations = [RewardInfo.JobStage!];
                        }
Given this code, I presume the issue is that we're passing the job stage as the rotation, but the profit-taker heists only give rewards at the *end* of the bounty, so they have only one reward table per bounty with one rotation, leading to the error. ``` if (job.xpAmounts.length > 1) { rotations = [RewardInfo.JobStage! % (job.xpAmounts.length - 1)]; } else { rotations = [RewardInfo.JobStage!]; } ```
Sainan removed the
pr'd for
 label 2025-05-04 17:28:20 -07:00
Sainan added the
pr'd for
 label 2025-05-04 17:53:40 -07:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
An existing implemention is incorrect
dependencies
Pull requests that update a dependency file
documentation
Improvements or additions to documentation
enhancement
New feature or request specific to the emulator
help wanted
Extra attention is needed
improvement
missing data
part of more major rehaul
Can't be worked on right now without merge conflicts later
pr'd for
Soon™
question
Further information is requested
unimplemented
you can do this
Considered easy enough for someone's first PR.
No Label
bug
pr'd for
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: OpenWF/SpaceNinjaServer#1964
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?