OpenWF/SpaceNinjaServer
28
29
Fork 34
Code Issues 26 Pull Requests 6 Actions Packages Projects Releases Activity

fix: give corresponding weapon when crafting Hound #1816

Merged
Sainan merged 2 commits from AMelonInsideLemon/SpaceNinjaServer:give-hound-weapon into main 2025-04-24 11:24:54 -07:00
Conversation 5 Commits 2 Files Changed 2 +14 -2
AMelonInsideLemon commented 2025-04-23 12:29:17 -07:00
Member
Copy Link
No description provided.
Sainan approved these changes 2025-04-23 12:33:31 -07:00
Dismissed
Sainan dismissed Sainan’s review 2025-04-23 15:29:14 -07:00
Sainan commented 2025-04-23 15:34:36 -07:00
Owner
Copy Link

Relevant data for this has been added in PE+ 0.5.58. Could you rebase your PR onto main (for f039998d71) and use ExportSentinels instead of this hardcoded map?

Relevant data for this has been added in PE+ 0.5.58. Could you rebase your PR onto main (for f039998d713c9cce45926af18d353e1f06d416ea) and use ExportSentinels instead of this hardcoded map?
AMelonInsideLemon force-pushed give-hound-weapon from 604ae5776a to 63752eb52c 2025-04-23 16:07:18 -07:00 Compare
AMelonInsideLemon added 1 commit 2025-04-23 16:07:29 -07:00
update to PE+ 0.5.58
All checks were successful
Build / build (pull_request) Successful in 43s
Details
ffa967c038
AMelonInsideLemon commented 2025-04-23 16:09:43 -07:00
Author
Member
Copy Link

done

done
Sainan reviewed 2025-04-23 16:31:28 -07:00
src/controllers/custom/getItemListsController.ts
@ -67,3 +67,3 @@
}
for (const [uniqueName, item] of Object.entries(ExportSentinels)) {
if (item.productCategory != "SpecialItems") {
if (item.productCategory == "Sentinels" || item.productCategory == "KubrowPets") {
Sainan commented 2025-04-23 16:31:28 -07:00
Owner
Copy Link

Not really related to this PR, but alongside this, maybe the MoaPets array should be removed from res again.

Not really related to this PR, but alongside this, maybe the MoaPets array should be removed from `res` again.
Sainan marked this conversation as resolved
Sainan approved these changes 2025-04-23 17:01:04 -07:00
Sainan merged commit 100aefcee4 into main 2025-04-24 11:24:54 -07:00
Sainan deleted branch give-hound-weapon 2025-04-24 11:24:54 -07:00
Sign in to join this conversation.
Reviewers
No Reviewers
Sainan
Labels
Clear labels
bug
An existing implemention is incorrect
dependencies
Pull requests that update a dependency file
documentation
Improvements or additions to documentation
enhancement
New feature or request specific to the emulator
help wanted
Extra attention is needed
improvement
missing data
part of more major rehaul
Can't be worked on right now without merge conflicts later
pr'd for
Soon™
question
Further information is requested
unimplemented
you can do this
Considered easy enough for someone's first PR.
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: OpenWF/SpaceNinjaServer#1816
No description provided.
Delete Branch "AMelonInsideLemon/SpaceNinjaServer:give-hound-weapon"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?