OpenWF/SpaceNinjaServer
12
6
Fork 15
Code Issues 44 Pull Requests 5 Actions Packages Projects Releases Activity

Railjack Salvage incorrectly rewarded as finished item #1645

New Issue
Closed
opened 2025-04-15 06:50:43 -07:00 by VampireKitten · 7 comments
VampireKitten commented 2025-04-15 06:50:43 -07:00
Contributor
Copy Link

Somewhat related to #911, Railjack components obtained as Salvage as... reward missions? are rewarded instead as completed items that... seem to be treated like skins?

2025-04-15T15:35:42:580 [0.1.0] debug:  generating random mission rewards {
  rewardManifests: [
    '/Lotus/Types/Game/MissionDecks/RailjackMissionRewards/EarthRailjackRewards'
  ],
  rotations: [ 0 ]
}
2025-04-15T15:35:42:581 [0.1.0] debug:  random mission drops: {
  '0': {
    StoreItem: '/Lotus/StoreItems/Upgrades/Skins/RailJack/ReactorLavanA',
    ItemCount: 1
  }
}

Which results in a completely cosmetic, non-stat changing item:
image.png

Components obtained as enemy drops, on the contrary, are handled as CrewshipSalvage:

  CrewShipRawSalvage: [
    {
      ItemCount: 1,
      ItemType: '/Lotus/Weapons/CrewShip/Laser/Blaster/VidarBlasterTierA'
    }
  ],

I am unsure if the vastly different item paths are still correct for either and if it's just being put in the wrong place, or if it's rewarding the wrong item altogether.

Somewhat related to #911, Railjack components obtained as Salvage as... reward missions? are rewarded instead as completed items that... seem to be treated like skins? ``` 2025-04-15T15:35:42:580 [0.1.0] debug: generating random mission rewards { rewardManifests: [ '/Lotus/Types/Game/MissionDecks/RailjackMissionRewards/EarthRailjackRewards' ], rotations: [ 0 ] } 2025-04-15T15:35:42:581 [0.1.0] debug: random mission drops: { '0': { StoreItem: '/Lotus/StoreItems/Upgrades/Skins/RailJack/ReactorLavanA', ItemCount: 1 } } ``` Which results in a completely cosmetic, non-stat changing item: ![image.png](/attachments/690c1180-d321-4558-a6b1-684283c50f00) Components obtained as enemy drops, on the contrary, are handled as CrewshipSalvage: ``` CrewShipRawSalvage: [ { ItemCount: 1, ItemType: '/Lotus/Weapons/CrewShip/Laser/Blaster/VidarBlasterTierA' } ], ``` I am unsure if the vastly different item paths are still correct for either and if it's just being put in the wrong place, or if it's rewarding the wrong item altogether.
image.png
2.5 MiB
Sainan added the
bug
 label 2025-04-15 06:51:49 -07:00
Sainan commented 2025-04-15 09:56:36 -07:00
Owner
Copy Link

/Lotus/StoreItems/Upgrades/Skins/RailJack/ReactorLavanA has product category CrewShipWeaponSkins, so from what I can tell, the server is adding this in the correct array?

`/Lotus/StoreItems/Upgrades/Skins/RailJack/ReactorLavanA` has product category `CrewShipWeaponSkins`, so from what I can tell, the server is adding this in the correct array?
VampireKitten commented 2025-04-15 10:03:07 -07:00
Author
Contributor
Copy Link

/Lotus/StoreItems/Upgrades/Skins/RailJack/ReactorLavanA has product category CrewShipWeaponSkins, so from what I can tell, the server is adding this in the correct array?

It should be being added into Salvage to be identified, then repaired, then finally added to the list of usable components with their unique stats.

The Lavan Reactor Mk1 should have a random Duration bonus of 20 to 40%, compared to the Sigmar Reactor's 0% bonus on all stats. As you can see in the screenshot provided in the issue, it has no stats. Same applies for every other piece of non-Salvage equipment, which are all being treated as skins with no stats rather than items with semi-random stats like Kuva Weapons.

image.png

> `/Lotus/StoreItems/Upgrades/Skins/RailJack/ReactorLavanA` has product category `CrewShipWeaponSkins`, so from what I can tell, the server is adding this in the correct array? It should be being added into *Salvage* to be identified, then repaired, then finally added to the list of usable components with their unique stats. The Lavan Reactor Mk1 should have a random Duration bonus of 20 to 40%, compared to the Sigmar Reactor's 0% bonus on all stats. As you can see in the screenshot provided in the issue, it has no stats. Same applies for every other piece of non-Salvage equipment, which are all being treated as skins with no stats rather than items with semi-random stats like Kuva Weapons. ![image.png](/attachments/0d50b553-df4a-400b-bde8-8d37575a8ca8)
image.png
14 KiB
Sainan commented 2025-04-15 10:05:32 -07:00
Owner
Copy Link
  1. None of that means anything to me.
  2. It means doubly-nothing in terms of which array in your inventory it should be.
1. None of that means anything to me. 2. It means doubly-nothing in terms of which array in your inventory it should be.
VampireKitten commented 2025-04-15 10:09:09 -07:00
Author
Contributor
Copy Link
  1. None of that means anything to me.
  2. It means doubly-nothing in terms of which array in your inventory it should be.

It means that no, it's not in the correct array. It should all be being added to CrewShipRawSalvage alongside parts obtained from killing enemies.

> 1. None of that means anything to me. > 2. It means doubly-nothing in terms of which array in your inventory it should be. It means that no, it's not in the correct array. It should all be being added to `CrewShipRawSalvage` alongside parts obtained from killing enemies.
badPointer commented 2025-04-15 10:16:08 -07:00
Copy Link

I tested Railjack drops again. Drops work and salvage is the correct item type (unlike whatever is going on here?), however salvage identification is unimplemented.

{"level":"error","message":"unknown endpoint POST /api/crewShipIdentifySalvage.php","timestamp":"2025-04-15T17:15:20.606Z","version":"0.1.0"}
{"level":"debug","message":"data provided to /api/crewShipIdentifySalvage.php: {\"ItemType\":\"/Lotus/Upgrades/Skins/RailJack/ReactorZektiA\"}","timestamp":"2025-04-15T17:15:20.607Z","version":"0.1.0"}

Shall I open a separate issue for it?

I tested Railjack drops again. Drops work and salvage is the correct item type (unlike whatever is going on here?), however salvage identification is unimplemented. ``` {"level":"error","message":"unknown endpoint POST /api/crewShipIdentifySalvage.php","timestamp":"2025-04-15T17:15:20.606Z","version":"0.1.0"} {"level":"debug","message":"data provided to /api/crewShipIdentifySalvage.php: {\"ItemType\":\"/Lotus/Upgrades/Skins/RailJack/ReactorZektiA\"}","timestamp":"2025-04-15T17:15:20.607Z","version":"0.1.0"} ``` Shall I open a separate issue for it?
VampireKitten commented 2025-04-15 10:18:20 -07:00
Author
Contributor
Copy Link

I tested Railjack drops again. Drops work and salvage is the correct item type (unlike whatever is going on here?), however salvage identification is unimplemented.

{"level":"error","message":"unknown endpoint POST /api/crewShipIdentifySalvage.php","timestamp":"2025-04-15T17:15:20.606Z","version":"0.1.0"}
{"level":"debug","message":"data provided to /api/crewShipIdentifySalvage.php: {\"ItemType\":\"/Lotus/Upgrades/Skins/RailJack/ReactorZektiA\"}","timestamp":"2025-04-15T17:15:20.607Z","version":"0.1.0"}

Shall I open a separate issue for it?

The issue isn't drops, it's mission rewards specifically.

Also, identification already has an issue: #911, which... you opened yourself, and I've already linked to here before.

> I tested Railjack drops again. Drops work and salvage is the correct item type (unlike whatever is going on here?), however salvage identification is unimplemented. > ``` > {"level":"error","message":"unknown endpoint POST /api/crewShipIdentifySalvage.php","timestamp":"2025-04-15T17:15:20.606Z","version":"0.1.0"} > {"level":"debug","message":"data provided to /api/crewShipIdentifySalvage.php: {\"ItemType\":\"/Lotus/Upgrades/Skins/RailJack/ReactorZektiA\"}","timestamp":"2025-04-15T17:15:20.607Z","version":"0.1.0"} > ``` > Shall I open a separate issue for it? The issue isn't drops, it's mission rewards specifically. Also, identification already has an issue: #911, which... you opened yourself, and I've already linked to here before.
badPointer commented 2025-04-15 10:19:19 -07:00
Copy Link

Also, identification already has an issue: #911, which... you opened yourself, and I've already linked to here before.

Apologies, it's been a bit since I opened that issue. Forgot about that.

> Also, identification already has an issue: #911, which... you opened yourself, and I've already linked to here before. Apologies, it's been a bit since I opened that issue. Forgot about that.
Sainan added the
pr'd for
 label 2025-04-15 16:56:30 -07:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
An existing implemention is incorrect
dependencies
Pull requests that update a dependency file
documentation
Improvements or additions to documentation
enhancement
New feature or request specific to the emulator
help wanted
Extra attention is needed
improvement
missing data
part of more major rehaul
Can't be worked on right now without merge conflicts later
pr'd for
Soon™
question
Further information is requested
unimplemented
No Label
bug
pr'd for
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: OpenWF/SpaceNinjaServer#1645
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?