OpenWF/SpaceNinjaServer
28
29
Fork 34
Code Issues 25 Pull Requests 2 Actions Packages Projects Releases Activity

fix: additional checks in bounty rewards #1626

Merged
Sainan merged 1 commits from AMelonInsideLemon/SpaceNinjaServer:check-locationTag into main 2025-04-15 06:10:26 -07:00
Conversation 6 Commits 1 Files Changed 1 +18 -13
AMelonInsideLemon commented 2025-04-14 09:16:55 -07:00
Member
Copy Link

Closes #1623

Closes #1623
AMelonInsideLemon added 1 commit 2025-04-14 09:16:56 -07:00
fix: addotian checks in bounty rewards
All checks were successful
Build / build (pull_request) Successful in 50s
Details
9d0fdd5e36 
Closes #1623
Sainan commented 2025-04-14 09:52:34 -07:00
Owner
Copy Link

I don't see what this is good for. Plus, this doesn't seem remotely related to the linked issue.

I don't see what this is good for. Plus, this doesn't seem remotely related to the linked issue.
VampireKitten commented 2025-04-14 09:53:43 -07:00
Contributor
Copy Link

I don't see what this is good for. Plus, this doesn't seem remotely related to the linked issue.

I added it to my server and it fixes the issue I had described in #1623.

> I don't see what this is good for. Plus, this doesn't seem remotely related to the linked issue. I added it to my server and it fixes the issue I had described in #1623.
Sainan commented 2025-04-14 09:59:03 -07:00
Owner
Copy Link

Well, that's probably because of the && locationTag condition, but the rest of this PR...

Well, that's probably because of the `&& locationTag` condition, but the rest of this PR...
AMelonInsideLemon commented 2025-04-14 10:03:15 -07:00
Author
Member
Copy Link

Yeah, lets keep
TypeError: Cannot read properties of undefined (reading 'length') while processing /api/missionInventoryUpdate.php request
TypeError: Cannot read properties of undefined (reading '0') while processing /api/missionInventoryUpdate.php request
instead of the more readable error

Yeah, lets keep `TypeError: Cannot read properties of undefined (reading 'length') while processing /api/missionInventoryUpdate.php request` `TypeError: Cannot read properties of undefined (reading '0') while processing /api/missionInventoryUpdate.php request` instead of the more readable error
Sainan reviewed 2025-04-14 10:08:20 -07:00
Sainan reviewed 2025-04-14 11:47:36 -07:00
src/services/missionInventoryUpdateService.ts
@ -1000,2 +1000,2 @@
rewardManifests.push(job.rewards);
rotations.push(ExportRewards[job.rewards].length - 1);
if (ExportRewards[job.rewards]) {
rewardManifests.push(job.rewards);
Sainan commented 2025-04-14 11:47:36 -07:00
Owner
Copy Link

Sorry, this line just confuses the fuck out of me. Why are you doing rewardManifests.push(job.rewards); when just a few lines earlier you have rewardManifests = [job.rewards]; ? Surely this is not intentional?

Sorry, this line just confuses the fuck out of me. Why are you doing `rewardManifests.push(job.rewards);` when just a few lines earlier you have `rewardManifests = [job.rewards];` ? Surely this is not intentional?
AMelonInsideLemon commented 2025-04-15 02:27:36 -07:00
Author
Member
Copy Link

When player doesn't fail any bonus objective Q stays true, and if this is last JobStage then we should give additional reward for that JobStage. That why there is push

When player doesn't fail any bonus objective `Q` stays true, and if this is last `JobStage` then we should give `additional` reward for that `JobStage`. That why there is push
Sainan merged commit 43f3917b09 into main 2025-04-15 06:10:26 -07:00
Sainan deleted branch check-locationTag 2025-04-15 06:10:26 -07:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
An existing implemention is incorrect
dependencies
Pull requests that update a dependency file
documentation
Improvements or additions to documentation
enhancement
New feature or request specific to the emulator
help wanted
Extra attention is needed
improvement
missing data
part of more major rehaul
Can't be worked on right now without merge conflicts later
pr'd for
Soon™
question
Further information is requested
unimplemented
you can do this
Considered easy enough for someone's first PR.
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: OpenWF/SpaceNinjaServer#1626
No description provided.
Delete Branch "AMelonInsideLemon/SpaceNinjaServer:check-locationTag"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?