OpenWF/SpaceNinjaServer
12
6
Fork 15
Code Issues 44 Pull Requests 5 Actions Packages Projects Releases Activity

feat: bounty item reward #1595

Merged
OrdisPrime merged 3 commits from AMelonInsideLemon/SpaceNinjaServer:bounty-mission-rewards into main 2025-04-13 05:51:03 -07:00
Conversation 4 Commits 3 Files Changed 1 +133 -8
AMelonInsideLemon commented 2025-04-12 12:44:43 -07:00
Contributor
Copy Link

Re #388
same as before I think this only missing Field Bounties and Arcana Isolation Vault

Re #388 same as before I think this only missing `Field Bounties` and `Arcana Isolation Vault`
AMelonInsideLemon added 1 commit 2025-04-12 12:44:43 -07:00
feat: bounty item reward
Some checks failed
Build / build (pull_request) Failing after 1m14s
Details
c13be616b1 
Re #388
same as before I think this only missing `Field Bounties` and `Arcana Isolation Vault`
AMelonInsideLemon added 1 commit 2025-04-12 12:48:41 -07:00
Update missionInventoryUpdateService.ts
All checks were successful
Build / build (pull_request) Successful in 1m24s
Details
4d337074cb
Sainan reviewed 2025-04-12 12:55:30 -07:00
src/services/missionInventoryUpdateService.ts Outdated
@ -934,0 +1058,4 @@
const tierSuffix = tierSuffixes[syndicateTag][tier];
if (rewardTable && tierSuffix) {
rewardManifests = [rewardTable + tierSuffix];
Sainan commented 2025-04-12 12:55:30 -07:00
Owner
Copy Link

The compression here is a bit needless and just complicates the code. I'd say just expand the string literals.

The compression here is a bit needless and just complicates the code. I'd say just expand the string literals.
Sainan marked this conversation as resolved
Sainan commented 2025-04-12 12:56:23 -07:00
Owner
Copy Link

Shouldn't this be all bounty rewards now, so closes the issue?

Shouldn't this be all bounty rewards now, so closes the issue?
AMelonInsideLemon commented 2025-04-12 13:01:13 -07:00
Author
Contributor
Copy Link

I think cetus tent(and other sources of that "virtual" bounties) reward's doesn't works, and that acrane iso vault from deimos too

I think cetus tent(and other sources of that "virtual" bounties) reward's doesn't works, and that acrane iso vault from deimos too
AMelonInsideLemon added 1 commit 2025-04-12 14:31:48 -07:00
Update missionInventoryUpdateService.ts
All checks were successful
Build / build (pull_request) Successful in 41s
Details
3a20c1c800
Sainan approved these changes 2025-04-12 14:33:49 -07:00
OrdisPrime merged commit b429eed46c into main 2025-04-13 05:51:03 -07:00
Sign in to join this conversation.
Reviewers
No Reviewers
Sainan
Labels
Clear labels
bug
An existing implemention is incorrect
dependencies
Pull requests that update a dependency file
documentation
Improvements or additions to documentation
enhancement
New feature or request specific to the emulator
help wanted
Extra attention is needed
improvement
missing data
part of more major rehaul
Can't be worked on right now without merge conflicts later
pr'd for
Soon™
question
Further information is requested
unimplemented
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: OpenWF/SpaceNinjaServer#1595
No description provided.
Delete Branch "AMelonInsideLemon/SpaceNinjaServer:bounty-mission-rewards"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?