"Erra" Quest cannot be set as finished (+ it breaks the "Complete All Quests" button) in WebUI #1574

New Issue

Animan8000 · 2025-04-11T08:16:36-07:00

Animan8000 commented

2025-04-11 08:16:36 -07:00

Worth noting that I have this issue on a fresh new account.

2025-04-11T17:16:13:190 [0.1.0] http:   POST /custom/manageQuests?accountId=67f930e556a8979de5827a10&nonce=7471731542374721&operation=completeKey&itemType=/Lotus/Types/Keys/NewWarIntroQuest/NewWarIntroKeyChain 500 12.722 ms - -
2025-04-11T17:16:13:325 [0.1.0] debug:  adding key chain items /Lotus/StoreItems/Types/Keys/NewWarQuest/NewWarQuestKeyChain for /Lotus/Types/Keys/NewWarIntroQuest/NewWarIntroKeyChain at stage 0
2025-04-11T17:16:13:325 [0.1.0] warn:   Quest key /Lotus/Types/Keys/NewWarQuest/NewWarQuestKeyChain already exists. It will not be added
2025-04-11T17:16:13:326 [0.1.0] error:  Error: inventory changes was empty after getting keychain items: should not happen while processing /custom/manageQuests request
    at giveKeyChainItem (D:\GitHub\spaceninjaserver\build\src\services\questService.js:178:15)
    at process.processTicksAndRejections (node:internal/process/task_queues:105:5)
    at async giveKeyChainStageTriggered (D:\GitHub\spaceninjaserver\build\src\services\questService.js:238:13)
    at async completeQuest (D:\GitHub\spaceninjaserver\build\src\services\questService.js:116:9)
    at async manageQuestsController (D:\GitHub\spaceninjaserver\build\src\controllers\custom\manageQuestsController.js:60:17)
2025-04-11T17:16:13:326 [0.1.0] http:   POST /custom/manageQuests?accountId=67f930e556a8979de5827a10&nonce=7471731542374721&operation=completeKey&itemType=/Lotus/Types/Keys/NewWarIntroQuest/NewWarIntroKeyChain 500 12.775 ms - -

Worth noting that I have this issue on a fresh new account. ``` 2025-04-11T17:16:13:190 [0.1.0] http: POST /custom/manageQuests?accountId=67f930e556a8979de5827a10&nonce=7471731542374721&operation=completeKey&itemType=/Lotus/Types/Keys/NewWarIntroQuest/NewWarIntroKeyChain 500 12.722 ms - - 2025-04-11T17:16:13:325 [0.1.0] debug: adding key chain items /Lotus/StoreItems/Types/Keys/NewWarQuest/NewWarQuestKeyChain for /Lotus/Types/Keys/NewWarIntroQuest/NewWarIntroKeyChain at stage 0 2025-04-11T17:16:13:325 [0.1.0] warn: Quest key /Lotus/Types/Keys/NewWarQuest/NewWarQuestKeyChain already exists. It will not be added 2025-04-11T17:16:13:326 [0.1.0] error: Error: inventory changes was empty after getting keychain items: should not happen while processing /custom/manageQuests request at giveKeyChainItem (D:\GitHub\spaceninjaserver\build\src\services\questService.js:178:15) at process.processTicksAndRejections (node:internal/process/task_queues:105:5) at async giveKeyChainStageTriggered (D:\GitHub\spaceninjaserver\build\src\services\questService.js:238:13) at async completeQuest (D:\GitHub\spaceninjaserver\build\src\services\questService.js:116:9) at async manageQuestsController (D:\GitHub\spaceninjaserver\build\src\controllers\custom\manageQuestsController.js:60:17) 2025-04-11T17:16:13:326 [0.1.0] http: POST /custom/manageQuests?accountId=67f930e556a8979de5827a10&nonce=7471731542374721&operation=completeKey&itemType=/Lotus/Types/Keys/NewWarIntroQuest/NewWarIntroKeyChain 500 12.775 ms - - ```

Sainan added the

bug

label 2025-04-11 08:51:28 -07:00

Sainan referenced a pull request that will close this issue

2025-04-11 10:11:05 -07:00

fix: only warn when addKeyChainItems does not change the inventory #1578

Sainan closed this issue

2025-04-12 06:14:22 -07:00

Sign in to join this conversation.