chore: improve changeDojoRoot #1522

Merged

Sainan merged 3 commits from sortid into main 2025-04-10 07:15:28 -07:00

Conversation 0 Commits 3 Files Changed 5 +12 -12

Sainan commented 2025-04-09 06:44:03 -07:00

Owner

Copy Link

Using SortId instead of actually changing the component ids.
What's strange is that providing/omitting SortId does seem to make a difference in regards to deco positioning, which is presumably what the POST body would be for. I've opted to simply always provide the SortId in hopes that this avoids the need for repositioning entirely.
Closes #1520

Using SortId instead of actually changing the component ids. What's strange is that providing/omitting SortId does seem to make a difference in regards to deco positioning, which is presumably what the POST body would be for. I've opted to simply always provide the SortId in hopes that this avoids the need for repositioning entirely. Closes #1520

Sainan added 1 commit 2025-04-09 06:44:03 -07:00

chore: improve changeDojoRoot ... 93066def43

Using SortId instead of actually changing the component ids.
What's strange is that providing/omitting SortId does seem to make a difference in regards to deco positioning, which is presumably what the POST body would be for. I've opted to simply always provide the SortId in hopes that this avoids the need for positioning entirely.

Sainan force-pushed sortid from 93066def43 to 41623807e1 2025-04-09 06:44:31 -07:00 Compare

Sainan added 1 commit 2025-04-09 06:49:30 -07:00

codify assumption 508440e0a6

Sainan added 1 commit 2025-04-09 07:02:46 -07:00

simplify b15ca46541

Sainan merged commit feb1dd4715 into main 2025-04-10 07:15:28 -07:00

Sainan deleted branch sortid 2025-04-10 07:15:28 -07:00

Sainan referenced this issue from a commit 2025-04-10 07:15:29 -07:00

chore: improve changeDojoRoot (#1522)

Sign in to join this conversation.

Reviewers

No Reviewers

Labels

Clear labels

bug

An existing implemention is incorrect

dependencies

Pull requests that update a dependency file

documentation

Improvements or additions to documentation

enhancement

New feature or request specific to the emulator

help wanted

Extra attention is needed

improvement

missing data

part of more major rehaul

Can't be worked on right now without merge conflicts later

pr'd for

Soon™

question

Further information is requested

unimplemented

No Label

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: OpenWF/SpaceNinjaServer#1522

No description provided.