Visual-only inbox attachments #1477

New Issue

Sainan · 2025-04-05T12:11:51-07:00

Sainan commented

2025-04-05 12:11:51 -07:00

Giving items only when reading the message seems incorrect for some cases, e.g. the first stage of the railjack quest:

            {
                "itemsToGiveWhenTriggered": [
                    "/Lotus/StoreItems/Types/Recipes/Railjack/RailjackCephalonBlueprint"
                ],
                "messageToSendWhenTriggered": {
                    "sender": "/Lotus/Language/Bosses/Ordis",
                    "title": "/Lotus/Language/Railjack/RailjackBuildQuestOrdisDockTitle",
                    "body": "/Lotus/Language/Railjack/RailjackBuildQuestOrdisDockBody",
                    "attachments": [
                        "/Lotus/Types/Recipes/Railjack/RailjackCephalonBlueprint"
                    ],
                    "countedAttachments": [],
                    "icon": "/Lotus/Interface/Icons/Npcs/Ordis.png",
                    "transmission": "/Lotus/Sounds/Dialog/CyQuest/CephalonCy/DConstructCy0010RJCephalon",
                    "highPriority": true
                }
            }

This should only give the blueprint once.

Giving items only when reading the message seems incorrect for some cases, e.g. the first stage of the railjack quest: ```json { "itemsToGiveWhenTriggered": [ "/Lotus/StoreItems/Types/Recipes/Railjack/RailjackCephalonBlueprint" ], "messageToSendWhenTriggered": { "sender": "/Lotus/Language/Bosses/Ordis", "title": "/Lotus/Language/Railjack/RailjackBuildQuestOrdisDockTitle", "body": "/Lotus/Language/Railjack/RailjackBuildQuestOrdisDockBody", "attachments": [ "/Lotus/Types/Recipes/Railjack/RailjackCephalonBlueprint" ], "countedAttachments": [], "icon": "/Lotus/Interface/Icons/Npcs/Ordis.png", "transmission": "/Lotus/Sounds/Dialog/CyQuest/CephalonCy/DConstructCy0010RJCephalon", "highPriority": true } } ``` This should only give the blueprint once.

Sainan added the

bug

label 2025-04-05 12:11:51 -07:00

OrdisPrime commented

2025-04-06 13:51:46 -07:00

Did you confirm that its actually given twice?
I suspect, the lua script does not call the giveKeyChainItem anymore and it is a leftover

Did you confirm that its actually given twice? I suspect, the lua script does not call the giveKeyChainItem anymore and it is a leftover

Sainan commented

2025-04-06 13:52:34 -07:00

My account did seem to get the blueprint twice, yeah.

OrdisPrime commented

2025-04-06 13:56:26 -07:00

Damn, might want to add an exception for certain items then?
Since, I am relatively certain inbox behaves the same as official hm

Damn, might want to add an exception for certain items then? Since, I am relatively certain inbox behaves the same as official hm

Sainan commented

2025-04-06 14:26:24 -07:00

I think inbox messages should have a "visual-only attachments" flag so there's no items given when reading it.

Idk if this is needed for all quests or only specific ones, but would still be useful either way.

I think inbox messages should have a "visual-only attachments" flag so there's no items given when reading it. Idk if this is needed for all quests or only specific ones, but would still be useful either way.

Sainan referenced a pull request that will close this issue

2025-04-06 16:18:50 -07:00

feat: add attVisualOnly to inbox messages #1499

Sainan closed this issue

2025-04-07 05:30:30 -07:00

Sign in to join this conversation.

2 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: OpenWF/SpaceNinjaServer#1477