OpenWF/SpaceNinjaServer
28
29
Fork 34
Code Issues 25 Pull Requests 2 Actions Packages Projects Releases Activity

chore: fix controllers exporting non-RequestHandler things #1468

Merged
Sainan merged 2 commits from no-controller-exports into main 2025-04-05 06:52:36 -07:00
Conversation 0 Commits 2 Files Changed 18 +243 -256
Sainan commented 2025-04-04 18:38:36 -07:00
Owner
Copy Link

I'm surprised JavaScript allows circular includes, but they still don't feel good.

I'm surprised JavaScript allows circular includes, but they still don't feel good.
Sainan added 1 commit 2025-04-04 18:38:37 -07:00
chore: fix controllers exporting non-RequestHandler things
All checks were successful
Build / build (18) (push) Successful in 43s
Details
Build / build (20) (push) Successful in 1m12s
Details
Build / build (22) (push) Successful in 1m4s
Details
Build / build (18) (pull_request) Successful in 44s
Details
Build / build (20) (pull_request) Successful in 1m14s
Details
Build / build (22) (pull_request) Successful in 1m1s
Details
0a8f2b9559
Sainan force-pushed no-controller-exports from 774d16950a to 067b524af1 2025-04-04 18:50:06 -07:00 Compare
Sainan force-pushed no-controller-exports from 067b524af1 to f0b60fc3fe 2025-04-04 18:51:49 -07:00 Compare
Sainan merged commit 49edebc1eb into main 2025-04-05 06:52:36 -07:00
Sainan deleted branch no-controller-exports 2025-04-05 06:52:36 -07:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
An existing implemention is incorrect
dependencies
Pull requests that update a dependency file
documentation
Improvements or additions to documentation
enhancement
New feature or request specific to the emulator
help wanted
Extra attention is needed
improvement
missing data
part of more major rehaul
Can't be worked on right now without merge conflicts later
pr'd for
Soon™
question
Further information is requested
unimplemented
you can do this
Considered easy enough for someone's first PR.
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: OpenWF/SpaceNinjaServer#1468
No description provided.
Delete Branch "no-controller-exports"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?