OpenWF/SpaceNinjaServer
12
6
Fork 15
Code Issues 44 Pull Requests 5 Actions Packages Projects Releases Activity

basic session management completed #11

Merged
AKCore merged 9 commits from main into main 2023-06-03 19:24:57 -07:00
Conversation 7 Commits 9 Files Changed 11 +213 -9
AKCore commented 2023-06-03 17:51:42 -07:00 (Migrated from github.com)
Copy Link

Session Management is very early but working as expected so far.

Session Management is very early but working as expected so far.
AngeloTadeucci (Migrated from github.com) requested changes 2023-06-03 18:03:52 -07:00
src/controllers/api/findSessionsController.ts
AngeloTadeucci (Migrated from github.com) commented 2023-06-03 17:57:00 -07:00
Copy Link

pls add curly braces everywhere

pls add curly braces everywhere
AngeloTadeucci (Migrated from github.com) commented 2023-06-03 17:58:10 -07:00
Copy Link

useless case, already handled above. also would suggest removing the else and using a return

useless case, already handled above. also would suggest removing the else and using a return
src/controllers/api/getNewRewardSeedController.ts
@ -5,2 +5,4 @@
};
function generateRewardSeed(): number {
const min = -Number.MAX_SAFE_INTEGER;
AngeloTadeucci (Migrated from github.com) commented 2023-06-03 17:58:28 -07:00
Copy Link

not being used?

not being used?
src/managers/sessionManager.ts
AngeloTadeucci (Migrated from github.com) commented 2023-06-03 17:59:47 -07:00
Copy Link

move interface to another file like /types/session.ts

move interface to another file like /types/session.ts
AngeloTadeucci (Migrated from github.com) commented 2023-06-03 18:00:43 -07:00
Copy Link

this is basically an 'any' type, could move it to another file an call it "LooseObject"

this is basically an 'any' type, could move it to another file an call it "LooseObject"
AngeloTadeucci (Migrated from github.com) commented 2023-06-03 18:01:52 -07:00
Copy Link

redundant else

redundant else
AngeloTadeucci (Migrated from github.com) commented 2023-06-03 18:03:43 -07:00
Copy Link

invert if

invert if
src/managers/sessionManager.ts
@ -0,0 +93,4 @@
if (!sessions.some(session => session.sessionId === sessionId)) {
return sessionId;
}
}
AngeloTadeucci (Migrated from github.com) commented 2023-06-03 18:03:06 -07:00
Copy Link

could remove this for loop and just use some type of UUID

could remove this for loop and just use some type of UUID
AKCore (Migrated from github.com) reviewed 2023-06-03 18:05:03 -07:00
src/controllers/api/getNewRewardSeedController.ts
@ -5,2 +5,4 @@
};
function generateRewardSeed(): number {
const min = -Number.MAX_SAFE_INTEGER;
AKCore (Migrated from github.com) commented 2023-06-03 18:05:03 -07:00
Copy Link

Just for the moment. it is going to be used for seed generation I removed it while testing because i thought it was breaking my join requests

Just for the moment. it is going to be used for seed generation I removed it while testing because i thought it was breaking my join requests
OrdisPrime (Migrated from github.com) reviewed 2023-06-03 18:08:36 -07:00
src/managers/sessionManager.ts
@ -0,0 +93,4 @@
if (!sessions.some(session => session.sessionId === sessionId)) {
return sessionId;
}
}
OrdisPrime (Migrated from github.com) commented 2023-06-03 18:08:36 -07:00
Copy Link

uuid package is really good, I can help to set it up.

uuid package is really good, I can help to set it up.
AKCore (Migrated from github.com) reviewed 2023-06-03 18:09:50 -07:00
src/controllers/api/findSessionsController.ts
AKCore (Migrated from github.com) commented 2023-06-03 18:09:50 -07:00
Copy Link

Fixed this code

Fixed this code
AKCore (Migrated from github.com) reviewed 2023-06-03 18:12:59 -07:00
src/managers/sessionManager.ts
AKCore (Migrated from github.com) commented 2023-06-03 18:12:59 -07:00
Copy Link

not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest

not redundant, its a flip in the case depending on if the input is a string or a findSessionRequest
AngeloTadeucci (Migrated from github.com) reviewed 2023-06-03 18:15:27 -07:00
src/managers/sessionManager.ts
AngeloTadeucci (Migrated from github.com) commented 2023-06-03 18:14:44 -07:00
Copy Link

i mean only the keyword is redundant. since you are returning in all cases inside the first if block.

i mean only the keyword is redundant. since you are returning in all cases inside the first if block.
AngeloTadeucci (Migrated from github.com) approved these changes 2023-06-03 19:00:44 -07:00
Sign in to join this conversation.
Reviewers
No Reviewers
AngeloTadeucci
Labels
Clear labels
bug
An existing implemention is incorrect
dependencies
Pull requests that update a dependency file
documentation
Improvements or additions to documentation
enhancement
New feature or request specific to the emulator
help wanted
Extra attention is needed
improvement
missing data
part of more major rehaul
Can't be worked on right now without merge conflicts later
pr'd for
Soon™
question
Further information is requested
unimplemented
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: OpenWF/SpaceNinjaServer#11
No description provided.
Delete Branch "main"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?