OpenWF/SpaceNinjaServer
12
6
Fork 14
Code Issues 44 Pull Requests 3 Actions Packages Projects Releases Activity

fix: send heart of deimos email when quest is given #1065

Merged
OrdisPrime merged 1 commits from deimos-email into main 2025-03-03 12:48:12 -08:00
Conversation 6 Commits 1 Files Changed 1 +12
Sainan commented 2025-03-02 02:48:47 -08:00
Owner
Copy Link

Fixes #1061

Fixes #1061
OrdisPrime commented 2025-03-02 04:14:40 -08:00
Owner
Copy Link

Problem is, people can deactivate and activate, and it would give the email over and over.
It has to be given upon retrieving the quest key I think.
I added a wip just to make sure you notice it.

Problem is, people can deactivate and activate, and it would give the email over and over. It has to be given upon retrieving the quest key I think. I added a wip just to make sure you notice it.
OrdisPrime changed title from fix: send heart of deimos email when quest is activated to WIP: fix: send heart of deimos email when quest is activated 2025-03-02 04:15:30 -08:00
Sainan commented 2025-03-02 04:28:56 -08:00
Author
Owner
Copy Link

Hmm, but based on what I'm told, it's supposed to be sent when activating the quest? Idk, the information around this is unclear.

Hmm, but based on what I'm told, it's supposed to be sent when activating the quest? Idk, the information around this is unclear.
OrdisPrime commented 2025-03-02 04:39:12 -08:00
Owner
Copy Link

Hmm, but based on what I'm told, it's supposed to be sent when activating the quest? Idk, the information around this is unclear.

But, you can just select another quest, and then heart of deimos again and it would resend the mail.
We could search the inbox to check if the mail is present.. but I think just hints that setactivequest is not the right place.
Must be given elsewhere and I think it should be given when the item is added to inv, it only happens once.

> Hmm, but based on what I'm told, it's supposed to be sent when activating the quest? Idk, the information around this is unclear. But, you can just select another quest, and then heart of deimos again and it would resend the mail. We could search the inbox to check if the mail is present.. but I think just hints that setactivequest is not the right place. Must be given elsewhere and I think it should be given when the item is added to inv, it only happens once.
Sainan commented 2025-03-02 04:49:51 -08:00
Author
Owner
Copy Link

Yeah, I definitely agree the concern you've raised is valid. Is there maybe some tracking related to the stages that could be used to know if the quest has been activated before or not?

Yeah, I definitely agree the concern you've raised is valid. Is there maybe some tracking related to the stages that could be used to know if the quest has been activated before or not?
Sainan force-pushed deimos-email from 7682622eb5 to 0ba29cae20 2025-03-02 07:37:40 -08:00 Compare
Sainan changed title from WIP: fix: send heart of deimos email when quest is activated to fix: send heart of deimos email when quest is given 2025-03-02 07:37:46 -08:00
OrdisPrime commented 2025-03-03 12:47:40 -08:00
Owner
Copy Link

Sorry, am a bit inactive for some days because of exams.

a stage has a "c" parameter, if it is >= than 0 the stage is completed.

Sorry, am a bit inactive for some days because of exams. a stage has a "c" parameter, if it is >= than 0 the stage is completed.
OrdisPrime commented 2025-03-03 12:48:06 -08:00
Owner
Copy Link

But your current approach looks perfect.

But your current approach looks perfect.
OrdisPrime merged commit f97bdea447 into main 2025-03-03 12:48:12 -08:00
OrdisPrime deleted branch deimos-email 2025-03-03 12:48:12 -08:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
An existing implemention is incorrect
dependencies
Pull requests that update a dependency file
documentation
Improvements or additions to documentation
enhancement
New feature or request specific to the emulator
help wanted
Extra attention is needed
improvement
missing data
part of more major rehaul
Can't be worked on right now without merge conflicts later
pr'd for
Soon™
question
Further information is requested
unimplemented
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: OpenWF/SpaceNinjaServer#1065
No description provided.
Delete Branch "deimos-email"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?