OpenWF/SpaceNinjaServer
12
6
Fork 15
Code Issues 44 Pull Requests 5 Actions Packages Projects Releases Activity

Inventory Infrastructure and Example for Suits #10

Merged
OrdisPrime merged 16 commits from inventory_basic into main 2023-06-03 18:06:22 -07:00
Conversation 14 Commits 16 Files Changed 13 +1834 -20
OrdisPrime commented 2023-06-03 17:15:45 -07:00 (Migrated from github.com)
Copy Link
No description provided.
AngeloTadeucci (Migrated from github.com) requested changes 2023-06-03 17:38:47 -07:00
src/controllers/api/inventoryController.ts
AngeloTadeucci (Migrated from github.com) commented 2023-06-03 17:26:15 -07:00
Copy Link

i dont think the comment is necessary

    const inventory = await Inventory.findOne({ accountOwnerId: accountId });
i dont think the comment is necessary ```suggestion const inventory = await Inventory.findOne({ accountOwnerId: accountId }); ```
AngeloTadeucci (Migrated from github.com) commented 2023-06-03 17:26:58 -07:00
Copy Link

check if inventory is undefined before trying toJson()

check if inventory is undefined before trying `toJson()`
src/controllers/api/inventoryController.ts
@ -1,11 +1,29 @@
import inventory from "@/static/fixed_responses/inventory.json";
/* eslint-disable @typescript-eslint/no-misused-promises */
import { toInventoryResponse } from "@/src/helpers/inventoryHelpers";
AngeloTadeucci (Migrated from github.com) commented 2023-06-03 17:24:58 -07:00
Copy Link

isnt disabled globally now?

isnt disabled globally now?
src/helpers/inventoryHelpers.ts
AngeloTadeucci (Migrated from github.com) commented 2023-06-03 17:37:24 -07:00
Copy Link

use non-relative import

use non-relative import
src/models/inventoryModel.ts
@ -0,0 +1,258 @@
import { Document, Schema, model } from "mongoose";
import { IInventoryDatabase, IInventoryResponse, ISuitDatabase, ISuitDocument, Oid } from "../types/inventoryTypes";
AngeloTadeucci (Migrated from github.com) commented 2023-06-03 17:37:15 -07:00
Copy Link

use non-relative import

use non-relative import
src/services/inventoryService.ts
AngeloTadeucci (Migrated from github.com) commented 2023-06-03 17:36:57 -07:00
Copy Link

use non-relative import

use non-relative import
OrdisPrime (Migrated from github.com) reviewed 2023-06-03 17:39:22 -07:00
src/controllers/api/inventoryController.ts
@ -1,11 +1,29 @@
import inventory from "@/static/fixed_responses/inventory.json";
/* eslint-disable @typescript-eslint/no-misused-promises */
import { toInventoryResponse } from "@/src/helpers/inventoryHelpers";
OrdisPrime (Migrated from github.com) commented 2023-06-03 17:39:22 -07:00
Copy Link

no idea it shouldn't be

no idea it shouldn't be
OrdisPrime (Migrated from github.com) reviewed 2023-06-03 17:39:50 -07:00
src/controllers/api/inventoryController.ts
OrdisPrime (Migrated from github.com) commented 2023-06-03 17:39:50 -07:00
Copy Link

it is important, because it is not present in the original response.

it is important, because it is not present in the original response.
OrdisPrime (Migrated from github.com) reviewed 2023-06-03 17:40:09 -07:00
src/controllers/api/inventoryController.ts
OrdisPrime (Migrated from github.com) commented 2023-06-03 17:40:09 -07:00
Copy Link

?. checks for undefined!

?. checks for undefined!
OrdisPrime (Migrated from github.com) reviewed 2023-06-03 17:40:44 -07:00
src/services/inventoryService.ts
OrdisPrime (Migrated from github.com) commented 2023-06-03 17:40:44 -07:00
Copy Link

done

done
AngeloTadeucci (Migrated from github.com) reviewed 2023-06-03 17:43:02 -07:00
src/controllers/api/inventoryController.ts
AngeloTadeucci (Migrated from github.com) commented 2023-06-03 17:43:01 -07:00
Copy Link

this comment doesn't explain nothing, it says its using accountOwnerId to find an inventory which is obvious.

this comment doesn't explain nothing, it says its using accountOwnerId to find an inventory which is obvious.
AngeloTadeucci (Migrated from github.com) reviewed 2023-06-03 17:43:17 -07:00
src/controllers/api/inventoryController.ts
@ -1,11 +1,29 @@
import inventory from "@/static/fixed_responses/inventory.json";
/* eslint-disable @typescript-eslint/no-misused-promises */
import { toInventoryResponse } from "@/src/helpers/inventoryHelpers";
AngeloTadeucci (Migrated from github.com) commented 2023-06-03 17:43:16 -07:00
Copy Link

then remove the one from .eslintrc

then remove the one from .eslintrc
AngeloTadeucci (Migrated from github.com) reviewed 2023-06-03 17:43:50 -07:00
src/controllers/api/inventoryController.ts
AngeloTadeucci (Migrated from github.com) commented 2023-06-03 17:43:49 -07:00
Copy Link

that's why you check before so you dont two undefined checks

that's why you check before so you dont two undefined checks
OrdisPrime (Migrated from github.com) reviewed 2023-06-03 17:44:53 -07:00
src/controllers/api/inventoryController.ts
OrdisPrime (Migrated from github.com) commented 2023-06-03 17:44:53 -07:00
Copy Link

it explains a lot.

I added the field accountOwnerId and everyone who knows the inventory structure would know the field is not originally there.

The purpose of the field is explained: it exists to find an account's corresponding inventory.

it explains a lot. I added the field accountOwnerId and everyone who knows the inventory structure would know the field is not originally there. The purpose of the field is explained: it exists to find an account's corresponding inventory.
OrdisPrime (Migrated from github.com) reviewed 2023-06-03 17:46:46 -07:00
src/controllers/api/inventoryController.ts
OrdisPrime (Migrated from github.com) commented 2023-06-03 17:46:46 -07:00
Copy Link

good suggestion!

good suggestion!
OrdisPrime (Migrated from github.com) reviewed 2023-06-03 17:46:59 -07:00
src/controllers/api/inventoryController.ts
OrdisPrime (Migrated from github.com) commented 2023-06-03 17:46:59 -07:00
Copy Link

I understand now what you mean

I understand now what you mean
OrdisPrime (Migrated from github.com) reviewed 2023-06-03 17:48:55 -07:00
src/controllers/api/inventoryController.ts
@ -1,11 +1,29 @@
import inventory from "@/static/fixed_responses/inventory.json";
/* eslint-disable @typescript-eslint/no-misused-promises */
import { toInventoryResponse } from "@/src/helpers/inventoryHelpers";
OrdisPrime (Migrated from github.com) commented 2023-06-03 17:48:55 -07:00
Copy Link

I agree with you that it is stupid to have the line in every file that has an async handler.

But I don't like to globally disable a warning. Ill turn the .eslintrc back on

I agree with you that it is stupid to have the line in every file that has an async handler. But I don't like to globally disable a warning. Ill turn the .eslintrc back on
AngeloTadeucci (Migrated from github.com) reviewed 2023-06-03 17:49:11 -07:00
src/controllers/api/inventoryController.ts
AngeloTadeucci (Migrated from github.com) commented 2023-06-03 17:49:04 -07:00
Copy Link

should that belong then inside inventoryModel.ts?

should that belong then inside inventoryModel.ts?
AngeloTadeucci (Migrated from github.com) approved these changes 2023-06-03 18:05:56 -07:00
src/controllers/api/inventoryController.ts
@ -8,1 +14,3 @@
response.json(inventory);
const inventory = await Inventory.findOne({ accountOwnerId: accountId });
AngeloTadeucci (Migrated from github.com) commented 2023-06-03 18:04:28 -07:00
Copy Link

remove log

remove log
Sign in to join this conversation.
Reviewers
No Reviewers
AngeloTadeucci
Labels
Clear labels
bug
An existing implemention is incorrect
dependencies
Pull requests that update a dependency file
documentation
Improvements or additions to documentation
enhancement
New feature or request specific to the emulator
help wanted
Extra attention is needed
improvement
missing data
part of more major rehaul
Can't be worked on right now without merge conflicts later
pr'd for
Soon™
question
Further information is requested
unimplemented
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: OpenWF/SpaceNinjaServer#10
No description provided.
Delete Branch "inventory_basic"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?