support legacy oid for BrandedSuits

src/controllers/api/inventoryController.ts

@@ -327,11 +327,6 @@ export const getInventoryResponse = async (
                 for (const upgrade of inventoryResponse.Upgrades) {
                     toLegacyOid(upgrade.ItemId);
                 }
-                if (inventoryResponse.BrandedSuits) {
-                    for (const id of inventoryResponse.BrandedSuits) {
-                        toLegacyOid(id);
-                    }
-                }
             }
         }
     }

src/helpers/inventoryHelpers.ts

@@ -26,7 +26,7 @@ export const toOid = (objectId: Types.ObjectId): IOid => {
 export function toOid2(objectId: Types.ObjectId, buildLabel: undefined): IOid;
 export function toOid2(objectId: Types.ObjectId, buildLabel: string | undefined): IOidWithLegacySupport;
 export function toOid2(objectId: Types.ObjectId, buildLabel: string | undefined): IOidWithLegacySupport {
-    if (buildLabel && version_compare(buildLabel, "2016.12.21.19.13") <= 0) {
+    if (buildLabel && version_compare(buildLabel, "2017.03.02.14.59") >= 0) {
         return { $id: objectId.toString() };
     }
     return { $oid: objectId.toString() };

src/types/inventoryTypes/inventoryTypes.ts

@@ -1,6 +1,6 @@
 /* eslint-disable @typescript-eslint/no-explicit-any */
 import { Types } from "mongoose";
-import { IOid, IMongoDate, IOidWithLegacySupport } from "../commonTypes";
+import { IOid, IMongoDate } from "../commonTypes";
 import {
     IColor,
     IItemConfig,
@@ -371,7 +371,7 @@ export interface IInventoryClient extends IDailyAffiliations, InventoryClientEqu
     EchoesHexConquestCacheScoreMission?: number;
     EchoesHexConquestActiveFrameVariants?: string[];
     EchoesHexConquestActiveStickers?: string[];
-    BrandedSuits?: IOidWithLegacySupport[];
+    BrandedSuits?: IOid[];
     LockedWeaponGroup?: ILockedWeaponGroupClient;
     HubNpcCustomizations?: IHubNpcCustomization[];
     Ship?: IOrbiter; // U22 and below, response only