From fa34b9997624435251eb6b154a7545646bf96338 Mon Sep 17 00:00:00 2001
From: Sainan <63328889+Sainan@users.noreply.github.com>
Date: Sun, 30 Mar 2025 05:11:17 -0700
Subject: [PATCH] chore: improve login error for unknown email + no auto-create
 (#1379)

Reviewed-on: https://onlyg.it/OpenWF/SpaceNinjaServer/pulls/1379
Co-authored-by: Sainan <63328889+Sainan@users.noreply.github.com>
Co-committed-by: Sainan <63328889+Sainan@users.noreply.github.com>
---
 src/controllers/api/loginController.ts | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/src/controllers/api/loginController.ts b/src/controllers/api/loginController.ts
index af7beb55..f01c405a 100644
--- a/src/controllers/api/loginController.ts
+++ b/src/controllers/api/loginController.ts
@@ -54,8 +54,12 @@ export const loginController: RequestHandler = async (request, response) => {
         }
     }
 
-    //email not found or incorrect password
-    if (!account || !isCorrectPassword(loginRequest.password, account.password)) {
+    if (!account) {
+        response.status(400).json({ error: "unknown user" });
+        return;
+    }
+
+    if (!isCorrectPassword(loginRequest.password, account.password)) {
         response.status(400).json({ error: "incorrect login data" });
         return;
     }