From f906cdb5e895ae77acef6158bd180a1125c01b25 Mon Sep 17 00:00:00 2001
From: Sainan <63328889+Sainan@users.noreply.github.com>
Date: Sun, 6 Apr 2025 10:18:01 -0700
Subject: [PATCH] fix: handle client providing an invalid loadout id at EOM
 upload (#1486)

Reviewed-on: https://onlyg.it/OpenWF/SpaceNinjaServer/pulls/1486
Co-authored-by: Sainan <63328889+Sainan@users.noreply.github.com>
Co-committed-by: Sainan <63328889+Sainan@users.noreply.github.com>
---
 src/services/missionInventoryUpdateService.ts | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/services/missionInventoryUpdateService.ts b/src/services/missionInventoryUpdateService.ts
index 60fda2d4..0f7b5e55 100644
--- a/src/services/missionInventoryUpdateService.ts
+++ b/src/services/missionInventoryUpdateService.ts
@@ -441,7 +441,12 @@ export const addMissionInventoryUpdates = async (
                                 _id: new Types.ObjectId(ItemId.$oid),
                                 ...loadoutConfigItemIdRemoved
                             };
-                            loadout.NORMAL.id(loadoutId)!.overwrite(loadoutConfigDatabase);
+                            const dbConfig = loadout.NORMAL.id(loadoutId);
+                            if (dbConfig) {
+                                dbConfig.overwrite(loadoutConfigDatabase);
+                            } else {
+                                logger.warn(`couldn't update loadout because there's no config with id ${loadoutId}`);
+                            }
                         }
                         await loadout.save();
                     }