From f5dc61018a60a620202a84b10239a8650961f457 Mon Sep 17 00:00:00 2001 From: Sainan <63328889+Sainan@users.noreply.github.com> Date: Thu, 10 Apr 2025 23:04:25 +0200 Subject: [PATCH] =?UTF-8?q?chore:=20don't=20use=20=3F=20for=20leaderboardS?= =?UTF-8?q?ervice=20parameters=20This=20means=20the=20argument=20can=20be?= =?UTF-8?q?=20omitted=20when=20we=20really=20mean=20that=20it=20can=20be?= =?UTF-8?q?=20undefined=20=E2=80=94=20but=20we=20still=20want=20it=20to=20?= =?UTF-8?q?be=20explicitly=20given.?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- src/services/leaderboardService.ts | 8 ++++---- src/services/statsService.ts | 3 ++- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/src/services/leaderboardService.ts b/src/services/leaderboardService.ts index b0e03518..2ef908f7 100644 --- a/src/services/leaderboardService.ts +++ b/src/services/leaderboardService.ts @@ -8,7 +8,7 @@ export const submitLeaderboardScore = async ( ownerId: string, displayName: string, score: number, - guildId?: string + guildId: string | undefined ): Promise => { let expiry: Date; if (schedule == "daily") { @@ -39,9 +39,9 @@ export const getLeaderboard = async ( leaderboard: string, before: number, after: number, - pivotId?: string, - guildId?: string, - guildTier?: number + pivotId: string | undefined, + guildId: string | undefined, + guildTier: number | undefined ): Promise => { const filter: { leaderboard: string; guildId?: string; guildTier?: number } = { leaderboard }; if (guildId) { diff --git a/src/services/statsService.ts b/src/services/statsService.ts index 601aae7b..626bbe27 100644 --- a/src/services/statsService.ts +++ b/src/services/statsService.ts @@ -378,7 +378,8 @@ export const updateStats = async (accountOwnerId: string, payload: IStatsUpdate) category, accountOwnerId, payload.displayName, - data as number + data as number, + payload.guildId ); break;