OpenWF/SpaceNinjaServer
12
6
Fork 15
Code Issues 45 Pull Requests 6 Actions Packages Projects Releases Activity

chrore(webui): don't add duplicates to datalists (#1510)
Some checks failed
Build Docker image / docker (push) Waiting to run
Details
Build / build (20) (push) Has been cancelled
Details
Build / build (18) (push) Has been cancelled
Details
Build / build (22) (push) Has been cancelled
Details

Browse Source 
Browsers will show all options, even if this makes no sense, causing some confusion for users.

Reviewed-on: #1510
Co-authored-by: Sainan <63328889+Sainan@users.noreply.github.com>
Co-committed-by: Sainan <63328889+Sainan@users.noreply.github.com>
This commit is contained in:
Sainan 2025-04-08 03:06:19 -07:00 committed by Sainan
parent 7f69667171
commit ef4973e694
1 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
static/webui/script.js
View File

@ -265,6 +265,7 @@ function fetchItemList() {
} else if (type == "uniqueLevelCaps") { } else if (type == "uniqueLevelCaps") {
uniqueLevelCaps = items; uniqueLevelCaps = items;
} else { } else {
const nameSet = new Set();
items.forEach(item => { items.forEach(item => {
if (item.name.includes("<ARCHWING> ")) { if (item.name.includes("<ARCHWING> ")) {
item.name = item.name.replace("<ARCHWING> ", ""); item.name = item.name.replace("<ARCHWING> ", "");
@ -311,20 +312,19 @@ function fetchItemList() {
document document
.getElementById("datalist-" + type + "-" + item.partType.slice(5)) .getElementById("datalist-" + type + "-" + item.partType.slice(5))
.appendChild(option); .appendChild(option);
}
} else if (item.badReason != "notraw") {
if (nameSet.has(item.name)) {
//console.log(`Not adding ${item.uniqueName} to datalist for ${type} due to duplicate display name: ${item.name}`);
} else { } else {
console.log(item.partType); nameSet.add(item.name);
const option = document.createElement("option"); const option = document.createElement("option");
option.setAttribute("data-key", item.uniqueName); option.setAttribute("data-key", item.uniqueName);
option.value = item.name; option.value = item.name;
document.getElementById("datalist-" + type).appendChild(option); document.getElementById("datalist-" + type).appendChild(option);
} }
} }
if (item.badReason != "notraw") {
const option = document.createElement("option");
option.setAttribute("data-key", item.uniqueName);
option.value = item.name;
document.getElementById("datalist-" + type).appendChild(option);
}
itemMap[item.uniqueName] = { ...item, type }; itemMap[item.uniqueName] = { ...item, type };
}); });
} }