OpenWF/SpaceNinjaServer
17
18
Fork 21
Code Issues 30 Pull Requests 2 Actions Packages Projects Releases Activity

chore: report unknown fields in updateChallengeProgress payload (#2210)
All checks were successful
Build / build (push) Successful in 1m19s
Details
Build Docker image / docker-arm64 (push) Successful in 58s
Details
Build Docker image / docker-amd64 (push) Successful in 1m10s
Details

Browse Source 
Reviewed-on: #2210
Co-authored-by: Sainan <63328889+Sainan@users.noreply.github.com>
Co-committed-by: Sainan <63328889+Sainan@users.noreply.github.com>
This commit is contained in:
Sainan 2025-06-19 16:18:49 -07:00 committed by Sainan
parent 88d4ba6340
commit e686a2d028
1 changed files with 27 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

39
src/controllers/api/updateChallengeProgressController.ts
View File

@ -4,6 +4,8 @@ import { getAccountForRequest } from "@/src/services/loginService";
import { addChallenges, getInventory } from "@/src/services/inventoryService";
import { IChallengeProgress, ISeasonChallenge } from "@/src/types/inventoryTypes/inventoryTypes";
import { IAffiliationMods } from "@/src/types/purchaseTypes";
import { getEntriesUnsafe } from "@/src/utils/ts-utils";
import { logger } from "@/src/utils/logger";
export const updateChallengeProgressController: RequestHandler = async (req, res) => {
const challenges = getJSONfromString<IUpdateChallengeProgressRequest>(String(req.body));
@ -13,9 +15,6 @@ export const updateChallengeProgressController: RequestHandler = async (req, res
account._id.toString(),
"ChallengesFixVersion ChallengeProgress SeasonChallengeHistory Affiliations"
);
if (challenges.ChallengesFixVersion !== undefined) {
inventory.ChallengesFixVersion = challenges.ChallengesFixVersion;
}
let affiliationMods: IAffiliationMods[] = [];
if (challenges.ChallengeProgress) {
affiliationMods = addChallenges(
@ -25,15 +24,30 @@ export const updateChallengeProgressController: RequestHandler = async (req, res
challenges.SeasonChallengeCompletions
);
}
if (challenges.SeasonChallengeHistory) {
challenges.SeasonChallengeHistory.forEach(({ challenge, id }) => {
const itemIndex = inventory.SeasonChallengeHistory.findIndex(i => i.challenge === challenge);
if (itemIndex !== -1) {
inventory.SeasonChallengeHistory[itemIndex].id = id;
} else {
inventory.SeasonChallengeHistory.push({ challenge, id });
}
});
for (const [key, value] of getEntriesUnsafe(challenges)) {
switch (key) {
case "ChallengesFixVersion":
inventory.ChallengesFixVersion = value;
break;
case "SeasonChallengeHistory":
value!.forEach(({ challenge, id }) => {
const itemIndex = inventory.SeasonChallengeHistory.findIndex(i => i.challenge === challenge);
if (itemIndex !== -1) {
inventory.SeasonChallengeHistory[itemIndex].id = id;
} else {
inventory.SeasonChallengeHistory.push({ challenge, id });
}
});
break;
case "ChallengeProgress":
case "SeasonChallengeCompletions":
case "ChallengePTS":
break;
default:
logger.warn(`unknown challenge progress entry`, { key, value });
}
}
await inventory.save();
@ -43,6 +57,7 @@ export const updateChallengeProgressController: RequestHandler = async (req, res
};
interface IUpdateChallengeProgressRequest {
ChallengePTS?: number;
ChallengesFixVersion?: number;
ChallengeProgress?: IChallengeProgress[];
SeasonChallengeHistory?: ISeasonChallenge[];