OpenWF/SpaceNinjaServer
21
24
Fork 24
Code Issues 22 Pull Requests 4 Actions Packages Projects Releases Activity

fix: infinite loop when attempting to generate loid commisions (#2399)
All checks were successful
Build / build (push) Successful in 1m2s
Details
Build Docker image / docker-amd64 (push) Successful in 1m17s
Details
Build Docker image / docker-arm64 (push) Successful in 1m4s
Details

Browse Source 
Reviewed-on: #2399
Co-authored-by: Sainan <63328889+Sainan@users.noreply.github.com>
Co-committed-by: Sainan <63328889+Sainan@users.noreply.github.com>
This commit is contained in:
Sainan 2025-07-04 03:26:41 -07:00 committed by Sainan
parent b2de8608c6
commit e09e5ebec2
1 changed files with 15 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
src/services/serversideVendorsService.ts
View File

@ -299,9 +299,12 @@ const generateVendorManifest = (
? numUncountedOffers + numCountedOffers
: manifest.numItems
? numUncountedOffers +
(useRng
? rng.randomInt(manifest.numItems.minValue, manifest.numItems.maxValue)
: manifest.numItems.minValue)
Math.min(
Object.values(remainingItemCapacity).reduce((a, b) => a + b, 0),
useRng
? rng.randomInt(manifest.numItems.minValue, manifest.numItems.maxValue)
: manifest.numItems.minValue
)
: manifest.items.length;
let i = 0;
const rollableOffers = manifest.items.filter(x => x.probability !== undefined) as (Omit<
@ -495,4 +498,13 @@ if (args.dev) {
) {
logger.warn(`self test failed for /Lotus/Types/Game/VendorManifests/Ostron/MaskSalesmanManifest`);
}
// strange case where numItems is 5 even tho only 3 offers can possibly be generated
const loid = getVendorManifestByTypeName(
"/Lotus/Types/Game/VendorManifests/EntratiLabs/EntratiLabsCommisionsManifest",
false
)!.VendorInfo.ItemManifest;
if (loid.length != 3) {
logger.warn(`self test failed for /Lotus/Types/Game/VendorManifests/EntratiLabs/EntratiLabsCommisionsManifest`);
}
}