OpenWF/SpaceNinjaServer
28
29
Fork 35
Code Issues 25 Pull Requests 8 Actions Packages Projects Releases Activity

ensure netracells completion is eligible for credits
All checks were successful
Build / build (pull_request) Successful in 1m39s
Details

Browse Source
This commit is contained in:
Sainan 2025-08-21 21:34:38 +02:00
parent 2fe9843429
commit d0fa88edbb
1 changed files with 17 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
src/services/missionInventoryUpdateService.ts
View File

@ -1085,6 +1085,22 @@ const droptableAliases: Record<string, string> = {
"/Lotus/Types/DropTables/WF1999DropTables/LasrianTankHardModeDropTable" "/Lotus/Types/DropTables/WF1999DropTables/LasrianTankHardModeDropTable"
}; };
const isEligibleForCreditReward = (rewardInfo: IRewardInfo, missions: IMission, node: IRegion): boolean => {
// (E)SO should not give credits for only completing zone 1, in which case it has no rewardQualifications (https://onlyg.it/OpenWF/SpaceNinjaServer/issues/1823)
if (getRotations(rewardInfo).length == 0) {
return missions.Tag == "SolNode720"; // Netracells don't use rewardQualifications but probably should give credits anyway
}
// The rest here might not be needed anymore, but just to be sure we don't give undue credits...
return (
node.missionIndex != 23 && // junction
node.missionIndex != 28 && // open world
missions.Tag != "SolNode761" && // the index
missions.Tag != "SolNode762" && // the index
missions.Tag != "SolNode763" && // the index
missions.Tag != "CrewBattleNode556" // free flight
);
};
//TODO: return type of partial missioninventoryupdate response //TODO: return type of partial missioninventoryupdate response
export const addMissionRewards = async ( export const addMissionRewards = async (
account: TAccountDocument, account: TAccountDocument,
@ -1177,15 +1193,7 @@ export const addMissionRewards = async (
const node = ExportRegions[missions.Tag]; const node = ExportRegions[missions.Tag];
//node based credit rewards for mission completion //node based credit rewards for mission completion
if ( if (isEligibleForCreditReward(rewardInfo, missions, node)) {
node.missionIndex != 23 && // junction
node.missionIndex != 28 && // open world
missions.Tag != "SolNode761" && // the index
missions.Tag != "SolNode762" && // the index
missions.Tag != "SolNode763" && // the index
missions.Tag != "CrewBattleNode556" && // free flight
getRotations(rewardInfo).length > 0 // (E)SO should not give credits for only completing zone 1, in which case it has no rewardQualifications (https://onlyg.it/OpenWF/SpaceNinjaServer/issues/1823)
) {
const levelCreditReward = getLevelCreditRewards(node); const levelCreditReward = getLevelCreditRewards(node);
missionCompletionCredits += levelCreditReward; missionCompletionCredits += levelCreditReward;
logger.debug(`levelCreditReward ${levelCreditReward}`); logger.debug(`levelCreditReward ${levelCreditReward}`);