OpenWF/SpaceNinjaServer
28
29
Fork 35
Code Issues 25 Pull Requests 9 Actions Packages Projects Releases Activity

chore: fix inconsistencies with getGuildEventScoreController (#2641)
Some checks failed
Build Docker image / docker-amd64 (push) Waiting to run
Details
Build / build (push) Has been cancelled
Details
Build Docker image / docker-arm64 (push) Has been cancelled
Details

Browse Source 
bring it more in line with the rest of the codebase

Reviewed-on: #2641
Co-authored-by: Sainan <63328889+Sainan@users.noreply.github.com>
Co-committed-by: Sainan <63328889+Sainan@users.noreply.github.com>
This commit is contained in:
Sainan 2025-08-16 09:52:36 -07:00 committed by Sainan
parent 62a6042c9c
commit cddd2cdd2b
2 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/controllers/api/getGuildEventScore.ts → src/controllers/api/getGuildEventScoreController.ts
View File

@ -11,7 +11,7 @@ export const getGuildEventScoreController: RequestHandler = async (req, res) =>
if (guild && guild.GoalProgress && goalId) { if (guild && guild.GoalProgress && goalId) {
const goal = guild.GoalProgress.find(x => x.goalId.toString() == goalId); const goal = guild.GoalProgress.find(x => x.goalId.toString() == goalId);
if (goal) { if (goal) {
return res.json({ res.json({
Tier: guild.Tier, Tier: guild.Tier,
GoalProgress: { GoalProgress: {
Count: goal.Count, Count: goal.Count,
@ -19,7 +19,8 @@ export const getGuildEventScoreController: RequestHandler = async (req, res) =>
_id: { $oid: goal.goalId } _id: { $oid: goal.goalId }
} }
}); });
return;
} }
} }
return res.json({}); res.json({});
}; };

2
src/routes/api.ts
View File

@ -62,7 +62,7 @@ import { getFriendsController } from "@/src/controllers/api/getFriendsController
import { getGuildContributionsController } from "@/src/controllers/api/getGuildContributionsController"; import { getGuildContributionsController } from "@/src/controllers/api/getGuildContributionsController";
import { getGuildController } from "@/src/controllers/api/getGuildController"; import { getGuildController } from "@/src/controllers/api/getGuildController";
import { getGuildDojoController } from "@/src/controllers/api/getGuildDojoController"; import { getGuildDojoController } from "@/src/controllers/api/getGuildDojoController";
import { getGuildEventScoreController } from "@/src/controllers/api/getGuildEventScore"; import { getGuildEventScoreController } from "@/src/controllers/api/getGuildEventScoreController";
import { getGuildLogController } from "@/src/controllers/api/getGuildLogController"; import { getGuildLogController } from "@/src/controllers/api/getGuildLogController";
import { getIgnoredUsersController } from "@/src/controllers/api/getIgnoredUsersController"; import { getIgnoredUsersController } from "@/src/controllers/api/getIgnoredUsersController";
import { getNewRewardSeedController } from "@/src/controllers/api/getNewRewardSeedController"; import { getNewRewardSeedController } from "@/src/controllers/api/getNewRewardSeedController";