From cddd2cdd2be206bf5057e114a2e9b5ca1cc55bf7 Mon Sep 17 00:00:00 2001
From: Sainan <63328889+Sainan@users.noreply.github.com>
Date: Sat, 16 Aug 2025 09:52:36 -0700
Subject: [PATCH] chore: fix inconsistencies with getGuildEventScoreController
 (#2641)

bring it more in line with the rest of the codebase

Reviewed-on: https://onlyg.it/OpenWF/SpaceNinjaServer/pulls/2641
Co-authored-by: Sainan <63328889+Sainan@users.noreply.github.com>
Co-committed-by: Sainan <63328889+Sainan@users.noreply.github.com>
---
 ...getGuildEventScore.ts => getGuildEventScoreController.ts} | 5 +++--
 src/routes/api.ts                                            | 2 +-
 2 files changed, 4 insertions(+), 3 deletions(-)
 rename src/controllers/api/{getGuildEventScore.ts => getGuildEventScoreController.ts} (93%)

diff --git a/src/controllers/api/getGuildEventScore.ts b/src/controllers/api/getGuildEventScoreController.ts
similarity index 93%
rename from src/controllers/api/getGuildEventScore.ts
rename to src/controllers/api/getGuildEventScoreController.ts
index 7e488bd4..df995021 100644
--- a/src/controllers/api/getGuildEventScore.ts
+++ b/src/controllers/api/getGuildEventScoreController.ts
@@ -11,7 +11,7 @@ export const getGuildEventScoreController: RequestHandler = async (req, res) =>
     if (guild && guild.GoalProgress && goalId) {
         const goal = guild.GoalProgress.find(x => x.goalId.toString() == goalId);
         if (goal) {
-            return res.json({
+            res.json({
                 Tier: guild.Tier,
                 GoalProgress: {
                     Count: goal.Count,
@@ -19,7 +19,8 @@ export const getGuildEventScoreController: RequestHandler = async (req, res) =>
                     _id: { $oid: goal.goalId }
                 }
             });
+            return;
         }
     }
-    return res.json({});
+    res.json({});
 };
diff --git a/src/routes/api.ts b/src/routes/api.ts
index f2c2da95..04d778b1 100644
--- a/src/routes/api.ts
+++ b/src/routes/api.ts
@@ -62,7 +62,7 @@ import { getFriendsController } from "@/src/controllers/api/getFriendsController
 import { getGuildContributionsController } from "@/src/controllers/api/getGuildContributionsController";
 import { getGuildController } from "@/src/controllers/api/getGuildController";
 import { getGuildDojoController } from "@/src/controllers/api/getGuildDojoController";
-import { getGuildEventScoreController } from "@/src/controllers/api/getGuildEventScore";
+import { getGuildEventScoreController } from "@/src/controllers/api/getGuildEventScoreController";
 import { getGuildLogController } from "@/src/controllers/api/getGuildLogController";
 import { getIgnoredUsersController } from "@/src/controllers/api/getIgnoredUsersController";
 import { getNewRewardSeedController } from "@/src/controllers/api/getNewRewardSeedController";