From ca1b6c31b6e5f3bb653268161a6c88796399f416 Mon Sep 17 00:00:00 2001 From: Sainan <63328889+Sainan@users.noreply.github.com> Date: Sat, 26 Apr 2025 11:57:03 -0700 Subject: [PATCH] fix: give rewards for completing a capture mission (#1872) Reviewed-on: https://onlyg.it/OpenWF/SpaceNinjaServer/pulls/1872 Co-authored-by: Sainan <63328889+Sainan@users.noreply.github.com> Co-committed-by: Sainan <63328889+Sainan@users.noreply.github.com> --- src/services/missionInventoryUpdateService.ts | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/src/services/missionInventoryUpdateService.ts b/src/services/missionInventoryUpdateService.ts index e758bd7f..e4007833 100644 --- a/src/services/missionInventoryUpdateService.ts +++ b/src/services/missionInventoryUpdateService.ts @@ -70,16 +70,21 @@ const getRotations = (rewardInfo: IRewardInfo, tierOverride?: number): number[] return rotations; } + const missionIndex = ExportRegions[rewardInfo.node].missionIndex; + // For Rescue missions - if (rewardInfo.node in ExportRegions && ExportRegions[rewardInfo.node].missionIndex == 3 && rewardInfo.rewardTier) { + if (rewardInfo.node in ExportRegions && missionIndex == 3 && rewardInfo.rewardTier) { return [rewardInfo.rewardTier]; } const rotationCount = rewardInfo.rewardQualifications?.length || 0; - // Empty or absent rewardQualifications should not give rewards: - // - Aborting a railjack mission (https://onlyg.it/OpenWF/SpaceNinjaServer/issues/1741) + // Empty or absent rewardQualifications should not give rewards when: // - Completing only 1 zone of (E)SO (https://onlyg.it/OpenWF/SpaceNinjaServer/issues/1823) + // - Aborting a railjack mission (https://onlyg.it/OpenWF/SpaceNinjaServer/issues/1741) + if (rotationCount == 0 && missionIndex != 30 && missionIndex != 32) { + return [0]; + } const rotationPattern = tierOverride === undefined