OpenWF/SpaceNinjaServer
12
6
Fork 15
Code Issues 46 Pull Requests 6 Actions Packages Projects Releases Activity

chore: improve addMissionInventoryUpdates
All checks were successful
Build / build (20) (push) Successful in 59s
Details
Build / build (18) (pull_request) Successful in 40s
Details
Build / build (18) (push) Successful in 42s
Details
Build / build (22) (push) Successful in 1m4s
Details
Build / build (20) (pull_request) Successful in 59s
Details
Build / build (22) (pull_request) Successful in 1m0s
Details

Browse Source 
"type this properly" & don't abort on mission failure
This commit is contained in:
Sainan 2025-03-08 15:21:55 +01:00
parent 3853fda60d
commit c2e5c9b581
1 changed files with 2 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/services/missionInventoryUpdateService.ts
View File

@ -65,12 +65,8 @@ const getRandomRewardByChance = (pool: IReward[]): IRngResult | undefined => {
export const addMissionInventoryUpdates = async ( export const addMissionInventoryUpdates = async (
inventory: HydratedDocument<IInventoryDatabase, InventoryDocumentProps>, inventory: HydratedDocument<IInventoryDatabase, InventoryDocumentProps>,
inventoryUpdates: IMissionInventoryUpdateRequest inventoryUpdates: IMissionInventoryUpdateRequest
): Promise<Partial<IInventoryDatabase> | undefined> => { ): Promise<IInventoryChanges> => {
//TODO: type this properly const inventoryChanges: IInventoryChanges = {};
const inventoryChanges: Partial<IInventoryDatabase> = {};
if (inventoryUpdates.MissionFailed === true) {
return;
}
if (inventoryUpdates.RewardInfo && inventoryUpdates.RewardInfo.periodicMissionTag) { if (inventoryUpdates.RewardInfo && inventoryUpdates.RewardInfo.periodicMissionTag) {
const tag = inventoryUpdates.RewardInfo.periodicMissionTag; const tag = inventoryUpdates.RewardInfo.periodicMissionTag;
const existingCompletion = inventory.PeriodicMissionCompletions.find(completion => completion.tag === tag); const existingCompletion = inventory.PeriodicMissionCompletions.find(completion => completion.tag === tag);