fix: allow completion of unknown nodes (#1395)

Reviewed-on: #1395
Co-authored-by: Sainan <63328889+Sainan@users.noreply.github.com>
Co-committed-by: Sainan <63328889+Sainan@users.noreply.github.com>

src/services/itemDataService.ts

@@ -24,7 +24,6 @@ import {
     ExportGear,
     ExportKeys,
     ExportRecipes,
-    ExportRegions,
     ExportResources,
     ExportSentinels,
     ExportWarframes,
@@ -34,7 +33,6 @@ import {
     IMissionReward,
     IPowersuit,
     IRecipe,
-    IRegion,
     TReward
 } from "warframe-public-export-plus";
 import questCompletionItems from "@/static/fixed_responses/questCompletionRewards.json";
@@ -192,16 +190,6 @@ export const getLevelKeyRewards = (
     };
 };
 
-export const getNode = (nodeName: string): IRegion => {
-    const node = ExportRegions[nodeName];
-    // eslint-disable-next-line @typescript-eslint/no-unnecessary-condition
-    if (!node) {
-        throw new Error(`Node ${nodeName} not found`);
-    }
-
-    return node;
-};
-
 export const getQuestCompletionItems = (questKey: string): ITypeCount[] | undefined => {
     if (questKey in questCompletionItems) {
         return questCompletionItems[questKey as keyof typeof questCompletionItems];

src/services/missionInventoryUpdateService.ts

@@ -4,6 +4,7 @@ import {
     ExportRegions,
     ExportRewards,
     IMissionReward as IMissionRewardExternal,
+    IRegion,
     IReward
 } from "warframe-public-export-plus";
 import { IMissionInventoryUpdateRequest, IRewardInfo } from "../types/requestTypes";
@@ -32,7 +33,7 @@ import {
 import { updateQuestKey } from "@/src/services/questService";
 import { HydratedDocument, Types } from "mongoose";
 import { IInventoryChanges } from "@/src/types/purchaseTypes";
-import { getLevelKeyRewards, getNode, toStoreItem } from "@/src/services/itemDataService";
+import { getLevelKeyRewards, toStoreItem } from "@/src/services/itemDataService";
 import { InventoryDocumentProps, TInventoryDatabaseDocument } from "@/src/models/inventoryModels/inventoryModel";
 import { getEntriesUnsafe } from "@/src/utils/ts-utils";
 import { IEquipmentClient } from "@/src/types/inventoryTypes/commonInventoryTypes";
@@ -469,15 +470,15 @@ export const addMissionRewards = async (
         }
     }
 
-    if (
+    // ignoring tags not in ExportRegions, because it can just be garbage:
-        missions &&
+    // - https://onlyg.it/OpenWF/SpaceNinjaServer/issues/1013
-        missions.Tag != "" // https://onlyg.it/OpenWF/SpaceNinjaServer/issues/1013
+    // - https://onlyg.it/OpenWF/SpaceNinjaServer/issues/1365
-    ) {
+    if (missions && missions.Tag in ExportRegions) {
-        const node = getNode(missions.Tag);
+        const node = ExportRegions[missions.Tag];
 
         //node based credit rewards for mission completion
         if (node.missionIndex !== 28) {
-            const levelCreditReward = getLevelCreditRewards(missions.Tag);
+            const levelCreditReward = getLevelCreditRewards(node);
             missionCompletionCredits += levelCreditReward;
             inventory.RegularCredits += levelCreditReward;
             logger.debug(`levelCreditReward ${levelCreditReward}`);
@@ -660,8 +661,8 @@ export const addFixedLevelRewards = (
     return missionBonusCredits;
 };
 
-function getLevelCreditRewards(nodeName: string): number {
+function getLevelCreditRewards(node: IRegion): number {
-    const minEnemyLevel = getNode(nodeName).minEnemyLevel;
+    const minEnemyLevel = node.minEnemyLevel;
 
     return 1000 + (minEnemyLevel - 1) * 100;