From ad2f143f1507467b8d56392957c7f223ee2c2644 Mon Sep 17 00:00:00 2001
From: Sainan <63328889+Sainan@users.noreply.github.com>
Date: Tue, 22 Apr 2025 09:59:30 -0700
Subject: [PATCH] feat: cleanup some problems in inventories at daily reset
 (#1767)

Reviewed-on: https://onlyg.it/OpenWF/SpaceNinjaServer/pulls/1767
Co-authored-by: Sainan <63328889+Sainan@users.noreply.github.com>
Co-committed-by: Sainan <63328889+Sainan@users.noreply.github.com>
---
 src/controllers/api/inventoryController.ts |  9 ++++++++-
 src/services/inventoryService.ts           | 20 ++++++++++++++++++++
 2 files changed, 28 insertions(+), 1 deletion(-)

diff --git a/src/controllers/api/inventoryController.ts b/src/controllers/api/inventoryController.ts
index bede097f..ab739c4c 100644
--- a/src/controllers/api/inventoryController.ts
+++ b/src/controllers/api/inventoryController.ts
@@ -14,7 +14,12 @@ import {
     ExportVirtuals
 } from "warframe-public-export-plus";
 import { applyCheatsToInfestedFoundry, handleSubsumeCompletion } from "@/src/services/infestedFoundryService";
-import { addMiscItems, allDailyAffiliationKeys, createLibraryDailyTask } from "@/src/services/inventoryService";
+import {
+    addMiscItems,
+    allDailyAffiliationKeys,
+    cleanupInventory,
+    createLibraryDailyTask
+} from "@/src/services/inventoryService";
 import { logger } from "@/src/utils/logger";
 import { catBreadHash } from "@/src/helpers/stringHelpers";
 
@@ -79,6 +84,8 @@ export const inventoryController: RequestHandler = async (request, response) =>
             }
         }
 
+        cleanupInventory(inventory);
+
         inventory.NextRefill = new Date((Math.trunc(Date.now() / 86400000) + 1) * 86400000);
         await inventory.save();
     }
diff --git a/src/services/inventoryService.ts b/src/services/inventoryService.ts
index fd6a597b..c9e81c78 100644
--- a/src/services/inventoryService.ts
+++ b/src/services/inventoryService.ts
@@ -1769,3 +1769,23 @@ export const setupKahlSyndicate = (inventory: TInventoryDatabaseDocument): void
         Tag: "KahlSyndicate"
     });
 };
+
+export const cleanupInventory = (inventory: TInventoryDatabaseDocument): void => {
+    let index = inventory.MiscItems.findIndex(x => x.ItemType == "");
+    if (index != -1) {
+        inventory.MiscItems.splice(index, 1);
+    }
+
+    index = inventory.Affiliations.findIndex(x => x.Tag == "KahlSyndicate");
+    if (index != -1 && !inventory.Affiliations[index].WeeklyMissions) {
+        logger.debug(`KahlSyndicate seems broken, removing it and setting up again`);
+        inventory.Affiliations.splice(index, 1);
+        setupKahlSyndicate(inventory);
+    }
+
+    const LibrarySyndicate = inventory.Affiliations.find(x => x.Tag == "LibrarySyndicate");
+    if (LibrarySyndicate && LibrarySyndicate.FreeFavorsEarned) {
+        logger.debug(`removing FreeFavorsEarned from LibrarySyndicate`);
+        LibrarySyndicate.FreeFavorsEarned = undefined;
+    }
+};