From a5bca9fa8ec948ef986a1a71795aa6fc8d6c0a48 Mon Sep 17 00:00:00 2001 From: Sainan <63328889+Sainan@users.noreply.github.com> Date: Wed, 16 Apr 2025 20:54:27 +0200 Subject: [PATCH] remove needless intermediate variable for ItemType --- src/controllers/api/sellController.ts | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/src/controllers/api/sellController.ts b/src/controllers/api/sellController.ts index cd7d51df..138cd3b4 100644 --- a/src/controllers/api/sellController.ts +++ b/src/controllers/api/sellController.ts @@ -177,8 +177,7 @@ export const sellController: RequestHandler = async (req, res) => { const index = inventory.CrewShipWeapons.findIndex(x => x._id.equals(sellItem.String)); if (index != -1) { if (payload.SellCurrency == "SC_Resources") { - const itemType = inventory.CrewShipWeapons[index].ItemType; - refundPartialBuildCosts(inventory, itemType, inventoryChanges); + refundPartialBuildCosts(inventory, inventory.CrewShipWeapons[index].ItemType, inventoryChanges); } inventory.CrewShipWeapons.splice(index, 1); freeUpSlot(inventory, InventorySlot.RJ_COMPONENT_AND_ARMAMENTS); @@ -201,8 +200,11 @@ export const sellController: RequestHandler = async (req, res) => { const index = inventory.CrewShipWeaponSkins.findIndex(x => x._id.equals(sellItem.String)); if (index != -1) { if (payload.SellCurrency == "SC_Resources") { - const itemType = inventory.CrewShipWeaponSkins[index].ItemType; - refundPartialBuildCosts(inventory, itemType, inventoryChanges); + refundPartialBuildCosts( + inventory, + inventory.CrewShipWeaponSkins[index].ItemType, + inventoryChanges + ); } inventory.CrewShipWeaponSkins.splice(index, 1); freeUpSlot(inventory, InventorySlot.RJ_COMPONENT_AND_ARMAMENTS);