From a15a7d070c7b91add8909ec7cee034b57e264ac1 Mon Sep 17 00:00:00 2001 From: Sainan <63328889+Sainan@users.noreply.github.com> Date: Thu, 17 Apr 2025 17:24:15 +0200 Subject: [PATCH] fix: provide proper response when unbranding a suit --- src/controllers/api/claimCompletedRecipeController.ts | 7 +++++-- src/types/purchaseTypes.ts | 1 + 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/src/controllers/api/claimCompletedRecipeController.ts b/src/controllers/api/claimCompletedRecipeController.ts index 880b2267..a2c8139f 100644 --- a/src/controllers/api/claimCompletedRecipeController.ts +++ b/src/controllers/api/claimCompletedRecipeController.ts @@ -18,6 +18,7 @@ import { import { IInventoryChanges } from "@/src/types/purchaseTypes"; import { IEquipmentClient } from "@/src/types/inventoryTypes/commonInventoryTypes"; import { InventorySlot } from "@/src/types/inventoryTypes/inventoryTypes"; +import { toOid } from "@/src/helpers/inventoryHelpers"; interface IClaimCompletedRecipeRequest { RecipeIds: IOid[]; @@ -80,6 +81,7 @@ export const claimCompletedRecipeController: RequestHandler = async (req, res) = } else { logger.debug("Claiming Recipe", { recipe, pendingRecipe }); + let BrandedSuits: undefined | IOid[]; if (recipe.secretIngredientAction == "SIA_SPECTRE_LOADOUT_COPY") { inventory.PendingSpectreLoadouts ??= []; inventory.SpectreLoadouts ??= []; @@ -104,9 +106,10 @@ export const claimCompletedRecipeController: RequestHandler = async (req, res) = inventory.BrandedSuits!.findIndex(x => x.equals(pendingRecipe.SuitToUnbrand)), 1 ); + BrandedSuits = [toOid(pendingRecipe.SuitToUnbrand!)]; } - let InventoryChanges = {}; + let InventoryChanges: IInventoryChanges = {}; if (recipe.consumeOnUse) { addRecipes(inventory, [ { @@ -134,6 +137,6 @@ export const claimCompletedRecipeController: RequestHandler = async (req, res) = }; } await inventory.save(); - res.json({ InventoryChanges }); + res.json({ InventoryChanges, BrandedSuits }); } }; diff --git a/src/types/purchaseTypes.ts b/src/types/purchaseTypes.ts index 1b4c9aca..8e722c05 100644 --- a/src/types/purchaseTypes.ts +++ b/src/types/purchaseTypes.ts @@ -1,3 +1,4 @@ +import { IOid } from "./commonTypes"; import { IEquipmentClient } from "./inventoryTypes/commonInventoryTypes"; import { IDroneClient,