chore: improve addMissionInventoryUpdates (#1121)
All checks were successful
Build / build (20) (push) Successful in 40s
Build / build (22) (push) Successful in 58s
Build Docker image / docker (push) Successful in 34s
Build / build (18) (push) Successful in 58s

Closes #1119

Reviewed-on: #1121
Co-authored-by: Sainan <sainan@calamity.inc>
Co-committed-by: Sainan <sainan@calamity.inc>
This commit is contained in:
Sainan 2025-03-08 06:29:05 -08:00 committed by OrdisPrime
parent 3853fda60d
commit 92d53e1c00

View File

@ -65,12 +65,8 @@ const getRandomRewardByChance = (pool: IReward[]): IRngResult | undefined => {
export const addMissionInventoryUpdates = async (
inventory: HydratedDocument<IInventoryDatabase, InventoryDocumentProps>,
inventoryUpdates: IMissionInventoryUpdateRequest
): Promise<Partial<IInventoryDatabase> | undefined> => {
//TODO: type this properly
const inventoryChanges: Partial<IInventoryDatabase> = {};
if (inventoryUpdates.MissionFailed === true) {
return;
}
): Promise<IInventoryChanges> => {
const inventoryChanges: IInventoryChanges = {};
if (inventoryUpdates.RewardInfo && inventoryUpdates.RewardInfo.periodicMissionTag) {
const tag = inventoryUpdates.RewardInfo.periodicMissionTag;
const existingCompletion = inventory.PeriodicMissionCompletions.find(completion => completion.tag === tag);