chore: use inventory projection for updateTheme (#1302)

Reviewed-on: #1302

src/controllers/api/updateThemeController.ts

@@ -1,25 +1,23 @@
 import { getAccountIdForRequest } from "@/src/services/loginService";
 import { getJSONfromString } from "@/src/helpers/stringHelpers";
-import { updateTheme } from "@/src/services/inventoryService";
-import { IThemeUpdateRequest } from "@/src/types/requestTypes";
 import { RequestHandler } from "express";
+import { getInventory } from "@/src/services/inventoryService";
 
-const updateThemeController: RequestHandler = async (request, response) => {
+export const updateThemeController: RequestHandler = async (request, response) => {
     const accountId = await getAccountIdForRequest(request);
-    const body = String(request.body);
+    const data = getJSONfromString<IThemeUpdateRequest>(String(request.body));
 
-    try {
+    const inventory = await getInventory(accountId, "ThemeStyle ThemeBackground ThemeSounds");
-        const json = getJSONfromString<IThemeUpdateRequest>(body);
+    if (data.Style) inventory.ThemeStyle = data.Style;
-        if (typeof json !== "object") {
+    if (data.Background) inventory.ThemeBackground = data.Background;
-            throw new Error("Invalid data format");
+    if (data.Sounds) inventory.ThemeSounds = data.Sounds;
-        }
+    await inventory.save();
-
-        await updateTheme(json, accountId);
-    } catch (err) {
-        console.error("Error parsing JSON data:", err);
-    }
 
     response.json({});
 };
 
-export { updateThemeController };
+interface IThemeUpdateRequest {
+    Style?: string;
+    Background?: string;
+    Sounds?: string;
+}

src/services/inventoryService.ts

@@ -29,11 +29,7 @@ import {
     ICrewShipWeaponClient
 } from "@/src/types/inventoryTypes/inventoryTypes";
 import { IGenericUpdate, IUpdateNodeIntrosResponse } from "../types/genericUpdate";
-import {
+import { IMissionInventoryUpdateRequest, IUpdateChallengeProgressRequest } from "../types/requestTypes";
-    IMissionInventoryUpdateRequest,
-    IThemeUpdateRequest,
-    IUpdateChallengeProgressRequest
-} from "../types/requestTypes";
 import { logger } from "@/src/utils/logger";
 import { convertInboxMessage, fromStoreItem, getExalted, getKeyChainItems } from "@/src/services/itemDataService";
 import {
@@ -891,15 +887,6 @@ export const updateGeneric = async (data: IGenericUpdate, accountId: string): Pr
     };
 };
 
-export const updateTheme = async (data: IThemeUpdateRequest, accountId: string): Promise<void> => {
-    const inventory = await getInventory(accountId);
-    if (data.Style) inventory.ThemeStyle = data.Style;
-    if (data.Background) inventory.ThemeBackground = data.Background;
-    if (data.Sounds) inventory.ThemeSounds = data.Sounds;
-
-    await inventory.save();
-};
-
 export const addEquipment = (
     inventory: TInventoryDatabaseDocument,
     category: TEquipmentKey,

src/types/requestTypes.ts

@@ -19,12 +19,6 @@ import {
     ICollectibleEntry
 } from "./inventoryTypes/inventoryTypes";
 
-export interface IThemeUpdateRequest {
-    Style?: string;
-    Background?: string;
-    Sounds?: string;
-}
-
 export interface IAffiliationChange {
     Tag: string;
     Standing: number;