From 525e3067c95b965d220fa9b62ac0c0100f3230d9 Mon Sep 17 00:00:00 2001
From: Sainan <63328889+Sainan@users.noreply.github.com>
Date: Sat, 12 Apr 2025 06:14:21 -0700
Subject: [PATCH] fix: only warn when addKeyChainItems does not change the
 inventory (#1578)

Reviewed-on: https://onlyg.it/OpenWF/SpaceNinjaServer/pulls/1578
Co-authored-by: Sainan <63328889+Sainan@users.noreply.github.com>
Co-committed-by: Sainan <63328889+Sainan@users.noreply.github.com>
---
 src/services/questService.ts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/services/questService.ts b/src/services/questService.ts
index bae74f66..85cefa4b 100644
--- a/src/services/questService.ts
+++ b/src/services/questService.ts
@@ -232,7 +232,7 @@ export const giveKeyChainItem = async (
     const inventoryChanges = await addKeyChainItems(inventory, keyChainInfo);
 
     if (isEmptyObject(inventoryChanges)) {
-        throw new Error("inventory changes was empty after getting keychain items: should not happen");
+        logger.warn("inventory changes was empty after getting keychain items: should not happen");
     }
     // items were added: update quest stage's i (item was given)
     updateQuestStage(inventory, keyChainInfo, { i: true });