From 5149d0e3820ac5983a782dcfaf70129d430f2611 Mon Sep 17 00:00:00 2001
From: Sainan <63328889+Sainan@users.noreply.github.com>
Date: Fri, 11 Apr 2025 06:54:47 -0700
Subject: [PATCH] chore: don't use ? for leaderboardService parameters (#1551)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

This means the argument can be omitted when we really mean that it can be undefined — but we still want it to be explicitly given.

Reviewed-on: https://onlyg.it/OpenWF/SpaceNinjaServer/pulls/1551
Co-authored-by: Sainan <63328889+Sainan@users.noreply.github.com>
Co-committed-by: Sainan <63328889+Sainan@users.noreply.github.com>
---
 src/services/leaderboardService.ts | 8 ++++----
 src/services/statsService.ts       | 3 ++-
 2 files changed, 6 insertions(+), 5 deletions(-)

diff --git a/src/services/leaderboardService.ts b/src/services/leaderboardService.ts
index b0e03518..2ef908f7 100644
--- a/src/services/leaderboardService.ts
+++ b/src/services/leaderboardService.ts
@@ -8,7 +8,7 @@ export const submitLeaderboardScore = async (
     ownerId: string,
     displayName: string,
     score: number,
-    guildId?: string
+    guildId: string | undefined
 ): Promise<void> => {
     let expiry: Date;
     if (schedule == "daily") {
@@ -39,9 +39,9 @@ export const getLeaderboard = async (
     leaderboard: string,
     before: number,
     after: number,
-    pivotId?: string,
-    guildId?: string,
-    guildTier?: number
+    pivotId: string | undefined,
+    guildId: string | undefined,
+    guildTier: number | undefined
 ): Promise<ILeaderboardEntryClient[]> => {
     const filter: { leaderboard: string; guildId?: string; guildTier?: number } = { leaderboard };
     if (guildId) {
diff --git a/src/services/statsService.ts b/src/services/statsService.ts
index 601aae7b..626bbe27 100644
--- a/src/services/statsService.ts
+++ b/src/services/statsService.ts
@@ -378,7 +378,8 @@ export const updateStats = async (accountOwnerId: string, payload: IStatsUpdate)
                                 category,
                                 accountOwnerId,
                                 payload.displayName,
-                                data as number
+                                data as number,
+                                payload.guildId
                             );
                             break;