chore: reimplement setWeaponSkillTree as a mongo query
	
		
			
	
		
	
	
		
	
		
			All checks were successful
		
		
	
	
		
			
				
	
				Build / build (18) (push) Successful in 1m19s
				
			
		
			
				
	
				Build / build (22) (push) Successful in 1m29s
				
			
		
			
				
	
				Build / build (18) (pull_request) Successful in 53s
				
			
		
			
				
	
				Build / build (20) (pull_request) Successful in 1m15s
				
			
		
			
				
	
				Build / build (22) (pull_request) Successful in 1m25s
				
			
		
			
				
	
				Build / build (20) (push) Successful in 46s
				
			
		
		
	
	
				
					
				
			
		
			All checks were successful
		
		
	
	Build / build (18) (push) Successful in 1m19s
				
			Build / build (22) (push) Successful in 1m29s
				
			Build / build (18) (pull_request) Successful in 53s
				
			Build / build (20) (pull_request) Successful in 1m15s
				
			Build / build (22) (pull_request) Successful in 1m25s
				
			Build / build (20) (push) Successful in 46s
				
			This is faster by like 1-2 ms
This commit is contained in:
		
							parent
							
								
									054abee62c
								
							
						
					
					
						commit
						43c4b2426d
					
				@ -1,18 +1,25 @@
 | 
				
			|||||||
import { RequestHandler } from "express";
 | 
					import { RequestHandler } from "express";
 | 
				
			||||||
import { getAccountIdForRequest } from "@/src/services/loginService";
 | 
					import { getAccountIdForRequest } from "@/src/services/loginService";
 | 
				
			||||||
import { getInventory } from "@/src/services/inventoryService";
 | 
					 | 
				
			||||||
import { getJSONfromString } from "@/src/helpers/stringHelpers";
 | 
					import { getJSONfromString } from "@/src/helpers/stringHelpers";
 | 
				
			||||||
import { WeaponTypeInternal } from "@/src/services/itemDataService";
 | 
					import { Inventory } from "@/src/models/inventoryModels/inventoryModel";
 | 
				
			||||||
 | 
					import { equipmentKeys, TEquipmentKey } from "@/src/types/inventoryTypes/inventoryTypes";
 | 
				
			||||||
 | 
					
 | 
				
			||||||
export const setWeaponSkillTreeController: RequestHandler = async (req, res) => {
 | 
					export const setWeaponSkillTreeController: RequestHandler = async (req, res) => {
 | 
				
			||||||
    const accountId = await getAccountIdForRequest(req);
 | 
					    const accountId = await getAccountIdForRequest(req);
 | 
				
			||||||
    const inventory = await getInventory(accountId, req.query.Category as string);
 | 
					 | 
				
			||||||
    const payload = getJSONfromString<ISetWeaponSkillTreeRequest>(String(req.body));
 | 
					    const payload = getJSONfromString<ISetWeaponSkillTreeRequest>(String(req.body));
 | 
				
			||||||
 | 
					
 | 
				
			||||||
    const item = inventory[req.query.Category as WeaponTypeInternal].id(req.query.ItemId as string)!;
 | 
					    if (equipmentKeys.indexOf(req.query.Category as TEquipmentKey) != -1) {
 | 
				
			||||||
    item.SkillTree = payload.SkillTree;
 | 
					        await Inventory.updateOne(
 | 
				
			||||||
 | 
					            {
 | 
				
			||||||
 | 
					                accountOwnerId: accountId,
 | 
				
			||||||
 | 
					                [`${req.query.Category as string}._id`]: req.query.ItemId as string
 | 
				
			||||||
 | 
					            },
 | 
				
			||||||
 | 
					            {
 | 
				
			||||||
 | 
					                [`${req.query.Category as string}.$.SkillTree`]: payload.SkillTree
 | 
				
			||||||
 | 
					            }
 | 
				
			||||||
 | 
					        );
 | 
				
			||||||
 | 
					    }
 | 
				
			||||||
 | 
					
 | 
				
			||||||
    await inventory.save();
 | 
					 | 
				
			||||||
    res.end();
 | 
					    res.end();
 | 
				
			||||||
};
 | 
					};
 | 
				
			||||||
 | 
					
 | 
				
			||||||
 | 
				
			|||||||
		Loading…
	
	
			
			x
			
			
		
	
		Reference in New Issue
	
	Block a user