OpenWF/SpaceNinjaServer
19
22
Fork 23
Code Issues 25 Pull Requests 4 Actions Packages Projects Releases Activity

chore: ignore invalid item ids in saveLoadout (#2320)
Some checks failed
Build Docker image / docker-amd64 (push) Waiting to run
Details
Build Docker image / docker-arm64 (push) Waiting to run
Details
Build / build (push) Has been cancelled
Details

Browse Source 
With the 'IsNew' flag + webui delete item, this is quite easy to trigger and shouldn't prevent the other changes from going through.

Reviewed-on: #2320
Co-authored-by: Sainan <63328889+Sainan@users.noreply.github.com>
Co-committed-by: Sainan <63328889+Sainan@users.noreply.github.com>
This commit is contained in:
Sainan 2025-06-26 19:39:46 -07:00 committed by Sainan
parent 4acd87aae6
commit 31e24c27ad
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/services/saveLoadoutService.ts
View File

@ -149,7 +149,8 @@ export const handleInventoryItemConfigChange = async (
} else { } else {
const inventoryItem = inventory.WeaponSkins.id(itemId); const inventoryItem = inventory.WeaponSkins.id(itemId);
if (!inventoryItem) { if (!inventoryItem) {
throw new Error(`inventory item WeaponSkins not found with id ${itemId}`); logger.warn(`inventory item WeaponSkins not found with id ${itemId}`);
continue;
} }
if ("Favorite" in itemConfigEntries) { if ("Favorite" in itemConfigEntries) {
inventoryItem.Favorite = itemConfigEntries.Favorite; inventoryItem.Favorite = itemConfigEntries.Favorite;
@ -177,7 +178,8 @@ export const handleInventoryItemConfigChange = async (
const inventoryItem = inventory[equipmentName].id(itemId); const inventoryItem = inventory[equipmentName].id(itemId);
if (!inventoryItem) { if (!inventoryItem) {
throw new Error(`inventory item ${equipmentName} not found with id ${itemId}`); logger.warn(`inventory item ${equipmentName} not found with id ${itemId}`);
continue;
} }
for (const [configId, config] of Object.entries(itemConfigEntries)) { for (const [configId, config] of Object.entries(itemConfigEntries)) {