move ShipInteriorColors to PersonalRooms as it is not per-ship

src/controllers/api/getShipController.ts

@@ -15,7 +15,7 @@ export const getShipController: RequestHandler = async (req, res) => {
     const personalRoomsDb = await getPersonalRooms(accountId);
     const personalRooms = personalRoomsDb.toJSON<IPersonalRooms>();
     const loadout = await getLoadout(accountId);
-    const ship = await getShip(personalRoomsDb.activeShipId, "ShipInteriorColors ShipAttachments SkinFlavourItem");
+    const ship = await getShip(personalRoomsDb.activeShipId, "ShipAttachments SkinFlavourItem");
 
     const getShipResponse: IGetShipResponse = {
         ShipOwnerId: accountId,
@@ -24,7 +24,7 @@ export const getShipController: RequestHandler = async (req, res) => {
             ...personalRooms.Ship,
             ShipId: toOid(personalRoomsDb.activeShipId),
             ShipInterior: {
-                Colors: ship.ShipInteriorColors,
+                Colors: personalRooms.ShipInteriorColors,
                 ShipAttachments: ship.ShipAttachments,
                 SkinFlavourItem: ship.SkinFlavourItem
             }

src/controllers/api/inventoryController.ts

@@ -20,7 +20,7 @@ const inventoryController: RequestHandler = async (request, response) => {
 
     const inventory = await Inventory.findOne({ accountOwnerId: account._id.toString() })
         .populate<{ LoadOutPresets: ILoadoutDatabase }>("LoadOutPresets")
-        .populate<{ Ships: IShipInventory }>("Ships", "-ShipInteriorColors");
+        .populate<{ Ships: IShipInventory }>("Ships");
 
     if (!inventory) {
         response.status(400).json({ error: "inventory was undefined" });

src/controllers/api/setShipCustomizationsController.ts

@@ -1,3 +1,4 @@
+import { getAccountIdForRequest } from "@/src/services/loginService";
 import { setShipCustomizations } from "@/src/services/shipCustomizationsService";
 import { ISetShipCustomizationsRequest } from "@/src/types/shipTypes";
 import { logger } from "@/src/utils/logger";
@@ -5,9 +6,10 @@ import { RequestHandler } from "express";
 
 export const setShipCustomizationsController: RequestHandler = async (req, res) => {
     try {
+        const accountId = await getAccountIdForRequest(req);
         const setShipCustomizationsRequest = JSON.parse(req.body as string) as ISetShipCustomizationsRequest;
 
-        const setShipCustomizationsResponse = await setShipCustomizations(setShipCustomizationsRequest);
+        const setShipCustomizationsResponse = await setShipCustomizations(accountId, setShipCustomizationsRequest);
         res.json(setShipCustomizationsResponse);
     } catch (error: unknown) {
         if (error instanceof Error) {

src/models/personalRoomsModel.ts

@@ -1,4 +1,5 @@
 import { toOid } from "@/src/helpers/inventoryHelpers";
+import { colorSchema } from "@/src/models/inventoryModels/inventoryModel";
 import { IOrbiter, IPersonalRoomsDatabase, PersonalRoomsModelType } from "@/src/types/personalRoomsTypes";
 import {
     IApartment,
@@ -131,6 +132,7 @@ const tailorShopDefault: ITailorShopDatabase = {
 export const personalRoomsSchema = new Schema<IPersonalRoomsDatabase>({
     personalRoomsOwnerId: Schema.Types.ObjectId,
     activeShipId: Schema.Types.ObjectId,
+    ShipInteriorColors: colorSchema,
     Ship: orbiterSchema,
     Apartment: apartmentSchema,
     TailorShop: { type: tailorShopSchema, default: tailorShopDefault }

src/models/shipModel.ts

@@ -8,7 +8,6 @@ const shipSchema = new Schema<IShipDatabase>(
     {
         ItemType: String,
         ShipOwnerId: Schema.Types.ObjectId,
-        ShipInteriorColors: colorSchema,
         ShipExteriorColors: colorSchema,
         AirSupportPower: String,
         ShipAttachments: { HOOD_ORNAMENT: String },

src/services/shipCustomizationsService.ts

@@ -2,7 +2,6 @@ import { getPersonalRooms } from "@/src/services/personalRoomsService";
 import { getShip } from "@/src/services/shipService";
 import {
     ISetShipCustomizationsRequest,
-    IShipDatabase,
     IShipDecorationsRequest,
     IShipDecorationsResponse,
     ISetPlacedDecoInfoRequest
@@ -10,25 +9,27 @@ import {
 import { logger } from "@/src/utils/logger";
 import { Types } from "mongoose";
 
-export const setShipCustomizations = async (shipCustomization: ISetShipCustomizationsRequest) => {
-    const ship = await getShip(new Types.ObjectId(shipCustomization.ShipId));
-
-    let shipChanges: Partial<IShipDatabase>;
+export const setShipCustomizations = async (
+    accountId: string,
+    shipCustomization: ISetShipCustomizationsRequest
+): Promise<void> => {
+    console.log(shipCustomization);
     if (shipCustomization.IsExterior) {
-        shipChanges = {
+        const ship = await getShip(new Types.ObjectId(shipCustomization.ShipId));
+        if (ship.ShipOwnerId.toString() == accountId) {
+            ship.set({
                 ShipExteriorColors: shipCustomization.Customization.Colors,
                 SkinFlavourItem: shipCustomization.Customization.SkinFlavourItem,
                 ShipAttachments: shipCustomization.Customization.ShipAttachments,
                 AirSupportPower: shipCustomization.AirSupportPower!
-        };
-    } else {
-        shipChanges = {
-            ShipInteriorColors: shipCustomization.Customization.Colors
-        };
-    }
-    ship.set(shipChanges);
-
+            });
             await ship.save();
+        }
+    } else {
+        const personalRooms = await getPersonalRooms(accountId);
+        personalRooms.ShipInteriorColors = shipCustomization.Customization.Colors;
+        await personalRooms.save();
+    }
 };
 
 export const handleSetShipDecorations = async (

src/types/personalRoomsTypes.ts

@@ -1,3 +1,4 @@
+import { IColor } from "@/src/types/inventoryTypes/commonInventoryTypes";
 import {
     IApartment,
     IRoom,
@@ -16,12 +17,14 @@ export interface IOrbiter {
 }
 
 export interface IPersonalRooms {
+    ShipInteriorColors: IColor;
     Ship: IOrbiter;
     Apartment: IApartment;
     TailorShop: ITailorShop;
 }
 
 export interface IPersonalRoomsDatabase {
+    ShipInteriorColors: IColor;
     personalRoomsOwnerId: Types.ObjectId;
     activeShipId: Types.ObjectId;
     Ship: IOrbiter;

src/types/shipTypes.ts

@@ -1,4 +1,4 @@
-import { Schema, Types } from "mongoose";
+import { Types } from "mongoose";
 import { IOid } from "@/src/types/commonTypes";
 import { IColor } from "@/src/types/inventoryTypes/commonInventoryTypes";
 import { ILoadoutClient } from "./saveLoadoutTypes";
@@ -34,8 +34,7 @@ export interface IShip {
 
 export interface IShipDatabase {
     ItemType: string;
-    ShipOwnerId: Schema.Types.ObjectId;
-    ShipInteriorColors?: IColor;
+    ShipOwnerId: Types.ObjectId;
     ShipExteriorColors?: IColor;
     AirSupportPower: string;
     ShipAttachments?: IShipAttachments;