OpenWF/SpaceNinjaServer
12
6
Fork 15
Code Issues 46 Pull Requests 6 Actions Packages Projects Releases Activity

chore: fix most explicit-function-return-type warnings

Browse Source
This commit is contained in:
Sainan 2024-10-17 22:36:27 +02:00
parent 9dbb0fe4bf
commit 177744690d
14 changed files with 51 additions and 36 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/controllers/api/getFriendsController.ts
View File

@ -1,6 +1,6 @@
import { Request, Response } from "express";
const getFriendsController = (_request: Request, response: Response) => {
const getFriendsController = (_request: Request, response: Response): void => {
response.writeHead(200, {
//Connection: "keep-alive",
//"Content-Encoding": "gzip",

4
src/helpers/inventoryHelpers.ts
View File

@ -1,4 +1,4 @@
import { IOid } from "@/src/types/commonTypes";
import { IMongoDate, IOid } from "@/src/types/commonTypes";
import { IInventoryResponse } from "@/src/types/inventoryTypes/inventoryTypes";
import { Types } from "mongoose";
@ -13,6 +13,6 @@ export const toOid = (objectId: Types.ObjectId): IOid => {
return { $oid: objectId.toString() } satisfies IOid;
};
export const toMongoDate = (date: Date) => {
export const toMongoDate = (date: Date): IMongoDate => {
return { $date: { $numberLong: date.getTime().toString() } };
};

2
src/helpers/purchaseHelpers.ts
View File

@ -5,7 +5,7 @@ export const isSlotPurchaseName = (slotPurchaseName: string): slotPurchaseName i
return slotPurchaseName in slotPurchaseNameToSlotName;
};
export const parseSlotPurchaseName = (slotPurchaseName: string) => {
export const parseSlotPurchaseName = (slotPurchaseName: string): SlotPurchaseName => {
if (!isSlotPurchaseName(slotPurchaseName)) throw new Error(`invalid slot name ${slotPurchaseName}`);
return slotPurchaseName;
};

2
src/helpers/stringHelpers.ts
View File

@ -17,7 +17,7 @@ export const getSubstringFromKeywordToKeyword = (str: string, keywordBegin: stri
return str.substring(beginIndex, endIndex + 1);
};
export const getIndexAfter = (str: string, searchWord: string) => {
export const getIndexAfter = (str: string, searchWord: string): number => {
const index = str.indexOf(searchWord);
if (index === -1) {
return -1;

2
src/middleware/middleware.ts
View File

@ -1,7 +1,7 @@
import { logger } from "@/src/utils/logger";
import { /*NextFunction,*/ Request, Response } from "express";
const unknownEndpointHandler = (request: Request, response: Response) => {
const unknownEndpointHandler = (request: Request, response: Response): void => {
logger.error(`unknown endpoint ${request.method} ${request.path}`);
if (request.body) {
logger.debug(`data provided to ${request.path}: ${String(request.body)}`);

2
src/models/inventoryModels/inventoryModel.ts
View File

@ -326,7 +326,7 @@ const MailboxSchema = new Schema<IMailbox>(
{
LastInboxId: {
type: Schema.Types.ObjectId,
set: (v: IMailbox["LastInboxId"]) => v.$oid.toString()
set: (v: IMailbox["LastInboxId"]): string => v.$oid.toString()
}
},
{ id: false, _id: false }

2
src/services/configService.ts
View File

@ -56,7 +56,7 @@ interface ILoggerConfig {
level: string; // "fatal" | "error" | "warn" | "info" | "http" | "debug" | "trace";
}
export const updateConfig = async (data: string) => {
export const updateConfig = async (data: string): Promise<void> => {
amnesia = true;
await fsPromises.writeFile(configPath, data);
Object.assign(config, JSON.parse(data));

52
src/services/inventoryService.ts
View File

@ -47,7 +47,7 @@ import { handleStoreItemAcquisition } from "./purchaseService";
export const createInventory = async (
accountOwnerId: Types.ObjectId,
defaultItemReferences: { loadOutPresetId: Types.ObjectId; ship: Types.ObjectId }
) => {
): Promise<void> => {
try {
const inventory = new Inventory({
...new_inventory,
@ -366,7 +366,7 @@ export const addItem = async (
};
//TODO: maybe genericMethod for all the add methods, they share a lot of logic
export const addSentinel = async (sentinelName: string, accountId: string) => {
export const addSentinel = async (sentinelName: string, accountId: string): Promise<IInventoryChanges> => {
const inventoryChanges: IInventoryChanges = {};
if (ExportSentinels[sentinelName]?.defaultWeapon) {
@ -399,11 +399,11 @@ export const addSentinel = async (sentinelName: string, accountId: string) => {
return inventoryChanges;
};
export const addSentinelWeapon = async (typeName: string, accountId: string) => {
export const addSentinelWeapon = async (typeName: string, accountId: string): Promise<IEquipmentClient> => {
const inventory = await getInventory(accountId);
const sentinelIndex = inventory.SentinelWeapons.push({ ItemType: typeName });
const changedInventory = await inventory.save();
return changedInventory.SentinelWeapons[sentinelIndex - 1].toJSON();
return changedInventory.SentinelWeapons[sentinelIndex - 1].toJSON<IEquipmentClient>();
};
export const addPowerSuit = async (powersuitName: string, accountId: string): Promise<IInventoryChanges> => {
@ -457,14 +457,19 @@ export const addSpecialItem = async (
(inventoryChanges.SpecialItems as object[]).push(changedInventory.SpecialItems[specialItemIndex - 1].toJSON());
};
export const addSpaceSuit = async (spacesuitName: string, accountId: string) => {
export const addSpaceSuit = async (spacesuitName: string, accountId: string): Promise<IEquipmentClient> => {
const inventory = await getInventory(accountId);
const suitIndex = inventory.SpaceSuits.push({ ItemType: spacesuitName, Configs: [], UpgradeVer: 101, XP: 0 });
const changedInventory = await inventory.save();
return changedInventory.SpaceSuits[suitIndex - 1].toJSON();
return changedInventory.SpaceSuits[suitIndex - 1].toJSON<IEquipmentClient>();
};
export const updateSlots = async (accountId: string, slotName: SlotNames, slotAmount: number, extraAmount: number) => {
export const updateSlots = async (
accountId: string,
slotName: SlotNames,
slotAmount: number,
extraAmount: number
): Promise<void> => {
const inventory = await getInventory(accountId);
inventory[slotName].Slots += slotAmount;
@ -537,7 +542,7 @@ export const updateGeneric = async (data: IGenericUpdate, accountId: string): Pr
await inventory.save();
};
export const updateTheme = async (data: IThemeUpdateRequest, accountId: string) => {
export const updateTheme = async (data: IThemeUpdateRequest, accountId: string): Promise<void> => {
const inventory = await getInventory(accountId);
if (data.Style) inventory.ThemeStyle = data.Style;
if (data.Background) inventory.ThemeBackground = data.Background;
@ -629,7 +634,7 @@ const addGearExpByCategory = (
inventory: IInventoryDatabaseDocument,
gearArray: IEquipmentClient[] | undefined,
categoryName: TEquipmentKey
) => {
): void => {
const category = inventory[categoryName];
gearArray?.forEach(({ ItemId, XP }) => {
@ -658,7 +663,7 @@ const addGearExpByCategory = (
});
};
export const addMiscItems = (inventory: IInventoryDatabaseDocument, itemsArray: IMiscItem[] | undefined) => {
export const addMiscItems = (inventory: IInventoryDatabaseDocument, itemsArray: IMiscItem[] | undefined): void => {
const { MiscItems } = inventory;
itemsArray?.forEach(({ ItemCount, ItemType }) => {
@ -673,7 +678,10 @@ export const addMiscItems = (inventory: IInventoryDatabaseDocument, itemsArray:
});
};
export const addShipDecorations = (inventory: IInventoryDatabaseDocument, itemsArray: IConsumable[] | undefined) => {
export const addShipDecorations = (
inventory: IInventoryDatabaseDocument,
itemsArray: IConsumable[] | undefined
): void => {
const { ShipDecorations } = inventory;
itemsArray?.forEach(({ ItemCount, ItemType }) => {
@ -688,7 +696,7 @@ export const addShipDecorations = (inventory: IInventoryDatabaseDocument, itemsA
});
};
export const addConsumables = (inventory: IInventoryDatabaseDocument, itemsArray: IConsumable[] | undefined) => {
export const addConsumables = (inventory: IInventoryDatabaseDocument, itemsArray: IConsumable[] | undefined): void => {
const { Consumables } = inventory;
itemsArray?.forEach(({ ItemCount, ItemType }) => {
@ -703,7 +711,7 @@ export const addConsumables = (inventory: IInventoryDatabaseDocument, itemsArray
});
};
export const addRecipes = (inventory: IInventoryDatabaseDocument, itemsArray: ITypeCount[] | undefined) => {
export const addRecipes = (inventory: IInventoryDatabaseDocument, itemsArray: ITypeCount[] | undefined): void => {
const { Recipes } = inventory;
itemsArray?.forEach(({ ItemCount, ItemType }) => {
@ -718,7 +726,7 @@ export const addRecipes = (inventory: IInventoryDatabaseDocument, itemsArray: IT
});
};
export const addMods = (inventory: IInventoryDatabaseDocument, itemsArray: IRawUpgrade[] | undefined) => {
export const addMods = (inventory: IInventoryDatabaseDocument, itemsArray: IRawUpgrade[] | undefined): void => {
const { RawUpgrades } = inventory;
itemsArray?.forEach(({ ItemType, ItemCount }) => {
const itemIndex = RawUpgrades.findIndex(i => i.ItemType === ItemType);
@ -735,7 +743,7 @@ export const addMods = (inventory: IInventoryDatabaseDocument, itemsArray: IRawU
export const addFusionTreasures = (
inventory: IInventoryDatabaseDocument,
itemsArray: IFusionTreasure[] | undefined
) => {
): void => {
const { FusionTreasures } = inventory;
itemsArray?.forEach(({ ItemType, ItemCount, Sockets }) => {
const itemIndex = FusionTreasures.findIndex(i => i.ItemType == ItemType && (i.Sockets || 0) == (Sockets || 0));
@ -749,7 +757,10 @@ export const addFusionTreasures = (
});
};
export const updateChallengeProgress = async (challenges: IUpdateChallengeProgressRequest, accountId: string) => {
export const updateChallengeProgress = async (
challenges: IUpdateChallengeProgressRequest,
accountId: string
): Promise<void> => {
const inventory = await getInventory(accountId);
addChallenges(inventory, challenges.ChallengeProgress);
@ -761,7 +772,7 @@ export const updateChallengeProgress = async (challenges: IUpdateChallengeProgre
export const addSeasonalChallengeHistory = (
inventory: IInventoryDatabaseDocument,
itemsArray: ISeasonChallenge[] | undefined
) => {
): void => {
const category = inventory.SeasonChallengeHistory;
itemsArray?.forEach(({ challenge, id }) => {
@ -775,7 +786,10 @@ export const addSeasonalChallengeHistory = (
});
};
export const addChallenges = (inventory: IInventoryDatabaseDocument, itemsArray: IChallengeProgress[] | undefined) => {
export const addChallenges = (
inventory: IInventoryDatabaseDocument,
itemsArray: IChallengeProgress[] | undefined
): void => {
const category = inventory.ChallengeProgress;
itemsArray?.forEach(({ Name, Progress }) => {
@ -790,7 +804,7 @@ export const addChallenges = (inventory: IInventoryDatabaseDocument, itemsArray:
});
};
const addMissionComplete = (inventory: IInventoryDatabaseDocument, { Tag, Completes }: IMission) => {
const addMissionComplete = (inventory: IInventoryDatabaseDocument, { Tag, Completes }: IMission): void => {
const { Missions } = inventory;
const itemIndex = Missions.findIndex(item => item.Tag === Tag);

5
src/services/loadoutService.ts
View File

@ -1,7 +1,8 @@
import { Loadout } from "@/src/models/inventoryModels/loadoutModel";
import { logger } from "@/src/utils/logger";
import { ILoadoutDatabase } from "../types/saveLoadoutTypes";
export const getLoadout = async (accountId: string) => {
export const getLoadout = async (accountId: string): Promise<ILoadoutDatabase> => {
const loadout = await Loadout.findOne({ loadoutOwnerId: accountId });
if (!loadout) {
@ -9,5 +10,5 @@ export const getLoadout = async (accountId: string) => {
throw new Error("loadout not found");
}
return loadout;
return loadout.toJSON();
};

4
src/services/loginService.ts
View File

@ -34,13 +34,13 @@ export const createAccount = async (accountData: IDatabaseAccount): Promise<IDat
}
};
export const createLoadout = async (accountId: Types.ObjectId) => {
export const createLoadout = async (accountId: Types.ObjectId): Promise<Types.ObjectId> => {
const loadout = new Loadout({ loadoutOwnerId: accountId });
const savedLoadout = await loadout.save();
return savedLoadout._id;
};
export const createPersonalRooms = async (accountId: Types.ObjectId, shipId: Types.ObjectId) => {
export const createPersonalRooms = async (accountId: Types.ObjectId, shipId: Types.ObjectId): Promise<void> => {
const personalRooms = new PersonalRooms({
...new_personal_rooms,
personalRoomsOwnerId: accountId,

2
src/services/missionInventoryUpdateService.ts
View File

@ -184,7 +184,7 @@ const addRewardResponse = (
ItemType: string,
ItemCount: number,
InventoryCategory: IInventoryFieldType
) => {
): void => {
if (!ItemType) return;
if (!InventoryChanges[InventoryCategory]) {

4
src/services/purchaseService.ts
View File

@ -25,13 +25,13 @@ import {
TRarity
} from "warframe-public-export-plus";
export const getStoreItemCategory = (storeItem: string) => {
export const getStoreItemCategory = (storeItem: string): string => {
const storeItemString = getSubstringFromKeyword(storeItem, "StoreItems/");
const storeItemElements = storeItemString.split("/");
return storeItemElements[1];
};
export const getStoreItemTypesCategory = (typesItem: string) => {
export const getStoreItemTypesCategory = (typesItem: string): string => {
const typesString = getSubstringFromKeyword(typesItem, "Types");
const typeElements = typesString.split("/");
if (typesItem.includes("StoreItems")) {

2
src/services/recipeService.ts
View File

@ -4,7 +4,7 @@ import { getRecipe } from "@/src/services/itemDataService";
import { logger } from "@/src/utils/logger";
import { Types } from "mongoose";
export const startRecipe = async (recipeName: string, accountId: string) => {
export const startRecipe = async (recipeName: string, accountId: string): Promise<{ RecipeId: { $oid?: string } }> => {
const recipe = getRecipe(recipeName);
if (!recipe) {

2
src/utils/logger.ts
View File

@ -103,7 +103,7 @@ export const logger = createLogger({
addColors(logLevels.colors);
export function registerLogFileCreationListener() {
export function registerLogFileCreationListener(): void {
errorLog.on("new", filename => logger.info(`Using error log file: ${filename}`));
combinedLog.on("new", filename => logger.info(`Using combined log file: ${filename}`));
errorLog.on("rotate", filename => logger.info(`Rotated error log file: ${filename}`));