From 0997f9567f0843fc274564b9cde83d9bdff4515d Mon Sep 17 00:00:00 2001
From: Sainan <63328889+Sainan@users.noreply.github.com>
Date: Fri, 6 Jun 2025 16:59:13 -0700
Subject: [PATCH] fix: cap nemesis rank (#2122)

Re #2121

Reviewed-on: https://onlyg.it/OpenWF/SpaceNinjaServer/pulls/2122
Co-authored-by: Sainan <63328889+Sainan@users.noreply.github.com>
Co-committed-by: Sainan <63328889+Sainan@users.noreply.github.com>
---
 src/controllers/api/nemesisController.ts | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/src/controllers/api/nemesisController.ts b/src/controllers/api/nemesisController.ts
index abd9180e..435f6791 100644
--- a/src/controllers/api/nemesisController.ts
+++ b/src/controllers/api/nemesisController.ts
@@ -150,17 +150,17 @@ export const nemesisController: RequestHandler = async (req, res) => {
             res.json(response);
         } else {
             const passcode = getNemesisPasscode(inventory.Nemesis!);
+            let RankIncrease: number | undefined;
             if (passcode[body.position] != body.guess) {
-                res.end();
-            } else {
-                inventory.Nemesis!.Rank += 1;
-                inventory.Nemesis!.InfNodes = getInfNodes(
-                    getNemesisManifest(inventory.Nemesis!.manifest),
-                    inventory.Nemesis!.Rank
-                );
+                const manifest = getNemesisManifest(inventory.Nemesis!.manifest);
+                if (inventory.Nemesis!.Rank + 1 < manifest.systemIndexes.length) {
+                    inventory.Nemesis!.Rank += 1;
+                    RankIncrease = 1;
+                }
+                inventory.Nemesis!.InfNodes = getInfNodes(manifest, inventory.Nemesis!.Rank);
                 await inventory.save();
-                res.json({ RankIncrease: 1 });
             }
+            res.json({ RankIncrease });
         }
     } else if ((req.query.mode as string) == "rs") {
         // report spawn; POST but no application data in body