From 03d770c4d544d7abfde95400b66865bb062280a7 Mon Sep 17 00:00:00 2001
From: AMelonInsideLemon <166175391+AMelonInsideLemon@users.noreply.github.com>
Date: Thu, 6 Mar 2025 22:49:51 +0100
Subject: [PATCH] fix(webui): remove unnecessary elements when changing
 language

---
 static/webui/index.html |  7 ++++---
 static/webui/script.js  | 39 ++++++++++++++++++++++++++-------------
 2 files changed, 30 insertions(+), 16 deletions(-)

diff --git a/static/webui/index.html b/static/webui/index.html
index 77389791..acb42b57 100644
--- a/static/webui/index.html
+++ b/static/webui/index.html
@@ -555,9 +555,7 @@
                                 <form class="mt-2" onsubmit="doChangeSupportedSyndicate(); return false;">
                                     <label class="form-label" for="changeSyndicate" data-loc="cheats_changeSupportedSyndicate"></label>
                                     <div class="input-group">
-                                        <select class="form-control" id="changeSyndicate">
-                                            <option value="" data-loc="cheats_none"></option>
-                                        </select>
+                                        <input class="form-control" id="changeSyndicate" list="datalist-Syndicates" />
                                         <button class="btn btn-primary" type="submit" data-loc="cheats_changeButton"></button>
                                     </div>
                                 </form>
@@ -593,6 +591,9 @@
     <datalist id="datalist-Sentinels"></datalist>
     <datalist id="datalist-ModularParts"></datalist>
     <datalist id="datalist-MechSuits"></datalist>
+    <datalist id="datalist-Syndicates">
+        <option data-key=""></option>
+    </datalist>
     <datalist id="datalist-miscitems"></datalist>
     <datalist id="datalist-mods">
         <option data-key="/Lotus/Upgrades/Mods/Fusers/LegendaryModFuser" value="Legendary Core"></option>
diff --git a/static/webui/script.js b/static/webui/script.js
index 1750f511..21a135e6 100644
--- a/static/webui/script.js
+++ b/static/webui/script.js
@@ -129,7 +129,11 @@ function setActiveLanguage(lang) {
 
     window.dictPromise = new Promise(resolve => {
         const webui_lang = ["en", "ru", "fr"].indexOf(lang) == -1 ? "en" : lang;
-        const script = document.createElement("script");
+        let script = document.getElementById("translations");
+        if (script) document.documentElement.removeChild(script);
+
+        script = document.createElement("script");
+        script.id = "translations";
         script.src = "/translations/" + webui_lang + ".js";
         script.onload = function () {
             updateLocElements();
@@ -157,6 +161,15 @@ function fetchItemList() {
         req.done(async data => {
             await dictPromise;
 
+            document.querySelectorAll('[id^="datalist-"]').forEach(datalist => {
+                datalist.innerHTML = "";
+            });
+
+            const syndicateNone = document.createElement("option");
+            syndicateNone.setAttribute("data-key", "");
+            syndicateNone.value = loc("cheats_none");
+            document.getElementById("datalist-Syndicates").appendChild(syndicateNone);
+
             window.archonCrystalUpgrades = data.archonCrystalUpgrades;
 
             const itemMap = {
@@ -198,15 +211,6 @@ function fetchItemList() {
                     });
                 } else if (type == "uniqueLevelCaps") {
                     uniqueLevelCaps = items;
-                } else if (type == "Syndicates") {
-                    items.forEach(item => {
-                        if (item.uniqueName.startsWith("RadioLegion")) item.name += " (" + item.uniqueName + ")";
-                        const option = document.createElement("option");
-                        option.value = item.uniqueName;
-                        option.innerHTML = item.name;
-                        document.getElementById("changeSyndicate").appendChild(option);
-                        itemMap[item.uniqueName] = { ...item, type };
-                    });
                 } else {
                     items.forEach(item => {
                         if ("badReason" in item) {
@@ -216,6 +220,9 @@ function fetchItemList() {
                                 item.name += " " + loc("code_badItem");
                             }
                         }
+                        if (type == "Syndicates" && item.uniqueName.startsWith("RadioLegion")) {
+                            item.name += " (" + item.uniqueName + ")";
+                        }
                         if (item.uniqueName.substr(0, 18) != "/Lotus/Types/Game/" && item.badReason != "notraw") {
                             const option = document.createElement("option");
                             option.setAttribute("data-key", item.uniqueName);
@@ -564,8 +571,10 @@ function updateInventory() {
                     single.loadRoute("/webui/inventory");
                 }
             }
-
-            document.getElementById("changeSyndicate").value = data.SupportedSyndicate ?? "";
+            document.getElementById("changeSyndicate").value =
+                [...document.querySelectorAll("#datalist-Syndicates option")].find(
+                    option => option.getAttribute("data-key") === (data.SupportedSyndicate ?? "")
+                )?.value ?? loc("cheats_none");
         });
     });
 }
@@ -1138,7 +1147,11 @@ function doImport() {
 }
 
 function doChangeSupportedSyndicate() {
-    const uniqueName = document.getElementById("changeSyndicate").value;
+    const uniqueName =
+        [...document.querySelectorAll("#datalist-Syndicates option")]
+            .find(option => option.value === document.getElementById("changeSyndicate").value)
+            ?.getAttribute("data-key") || "";
+
     revalidateAuthz(() => {
         $.get("/api/setSupportedSyndicate.php?" + window.authz + "&syndicate=" + uniqueName).done(function () {
             updateInventory();