chore: faithful response to getGuild & getGuildLog when not in a clan (#1159)

Reviewed-on: #1159

src/controllers/api/getGuildController.ts

@@ -28,7 +28,7 @@ const getGuildController: RequestHandler = async (req, res) => {
             return;
         }
     }
-    res.json({});
+    res.sendStatus(200);
 };
 
 export { getGuildController };

src/controllers/api/getGuildLogController.ts

@@ -6,6 +6,11 @@ import { IMongoDate } from "@/src/types/commonTypes";
 import { RequestHandler } from "express";
 
 export const getGuildLogController: RequestHandler = async (req, res) => {
+    const accountId = await getAccountIdForRequest(req);
+    const inventory = await getInventory(accountId);
+    if (inventory.GuildId) {
+        const guild = await Guild.findOne({ _id: inventory.GuildId });
+        if (guild) {
             const log: Record<string, IGuildLogEntryClient[]> = {
                 RoomChanges: [],
                 TechChanges: [],
@@ -13,11 +18,6 @@ export const getGuildLogController: RequestHandler = async (req, res) => {
                 StandingsUpdates: [],
                 ClassChanges: []
             };
-    const accountId = await getAccountIdForRequest(req);
-    const inventory = await getInventory(accountId);
-    if (inventory.GuildId) {
-        const guild = await Guild.findOne({ _id: inventory.GuildId });
-        if (guild) {
             guild.ClassChanges?.forEach(entry => {
                 log.ClassChanges.push({
                     dateTime: toMongoDate(entry.dateTime),
@@ -25,9 +25,11 @@ export const getGuildLogController: RequestHandler = async (req, res) => {
                     details: entry.details
                 });
             });
-        }
-    }
             res.json(log);
+            return;
+        }
+    }
+    res.sendStatus(200);
 };
 
 interface IGuildLogEntryClient {