OpenWF/SpaceNinjaServer
28
29
Fork 35
Code Issues 23 Pull Requests 1 Actions Packages Projects Releases Activity

chore: don't validate Nonce in query
All checks were successful
Build / build (18) (push) Successful in 42s
Details
Build / build (22) (push) Successful in 1m12s
Details
Build / build (20) (push) Successful in 1m13s
Details
Build / build (18) (pull_request) Successful in 43s
Details
Build / build (20) (pull_request) Successful in 1m12s
Details
Build / build (22) (pull_request) Successful in 1m13s
Details

Browse Source 
By asking MongoDB to simply find the account by the ID and then validating the nonce ourselves, we save roughly 1ms.
This commit is contained in:
Sainan 2025-03-27 00:55:50 +01:00
parent 5f9475f750
commit 02334f4a7e
1 changed files with 2 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/services/loginService.ts
View File

@ -74,11 +74,8 @@ export const getAccountForRequest = async (req: Request): Promise<TAccountDocume
throw new Error("Request is missing nonce parameter"); throw new Error("Request is missing nonce parameter");
} }
const account = await Account.findOne({ const account = await Account.findById(req.query.accountId);
_id: req.query.accountId, if (!account || account.Nonce != nonce) {
Nonce: nonce
});
if (!account) {
throw new Error("Invalid accountId-nonce pair"); throw new Error("Invalid accountId-nonce pair");
} }
if (account.Dropped && req.query.ct) { if (account.Dropped && req.query.ct) {