improve variable name

.github/workflows/build.yml

@@ -13,13 +13,4 @@ jobs:
             - run: npm ci
             - run: cp config.json.example config.json
             - run: npm run verify
-            - run: npm run lint:ci
+            - run: npm run lint
-            - run: npm run prettier
-            - name: Fail if there are uncommitted changes
-              run: |
-                  if [[ -n "$(git status --porcelain)" ]]; then
-                    echo "Uncommitted changes detected:"
-                    git status
-                    git diff
-                    exit 1
-                  fi

package.json

@@ -9,7 +9,6 @@
     "build": "tsc --incremental --sourceMap && ncp static/webui build/static/webui",
     "verify": "tsgo --noEmit",
     "lint": "eslint --ext .ts .",
-    "lint:ci": "eslint --ext .ts --rule \"prettier/prettier: off\" .",
     "lint:fix": "eslint --fix --ext .ts .",
     "prettier": "prettier --write .",
     "update-translations": "cd scripts && node update-translations.js"

src/controllers/api/clearDialogueHistoryController.ts

@@ -7,8 +7,6 @@ export const clearDialogueHistoryController: RequestHandler = async (req, res) =
     const inventory = await getInventory(accountId);
     const request = JSON.parse(String(req.body)) as IClearDialogueRequest;
     if (inventory.DialogueHistory && inventory.DialogueHistory.Dialogues) {
-        inventory.DialogueHistory.Resets ??= 0;
-        inventory.DialogueHistory.Resets += 1;
         for (const dialogueName of request.Dialogues) {
             const index = inventory.DialogueHistory.Dialogues.findIndex(x => x.DialogueName == dialogueName);
             if (index != -1) {

src/controllers/api/saveDialogueController.ts

@@ -1,7 +1,6 @@
-import { addEmailItem, getInventory } from "@/src/services/inventoryService";
+import { getInventory } from "@/src/services/inventoryService";
 import { getAccountIdForRequest } from "@/src/services/loginService";
 import { ICompletedDialogue } from "@/src/types/inventoryTypes/inventoryTypes";
-import { IInventoryChanges } from "@/src/types/purchaseTypes";
 import { logger } from "@/src/utils/logger";
 import { RequestHandler } from "express";
 
@@ -22,10 +21,9 @@ export const saveDialogueController: RequestHandler = async (req, res) => {
         if (!inventory.DialogueHistory) {
             throw new Error("bad inventory state");
         }
-        if (request.OtherDialogueInfos.length != 0) {
+        if (request.QueuedDialogues.length != 0 || request.OtherDialogueInfos.length != 0) {
             logger.error(`saveDialogue request not fully handled: ${String(req.body)}`);
         }
-        const inventoryChanges: IInventoryChanges = {};
         inventory.DialogueHistory.Dialogues ??= [];
         let dialogue = inventory.DialogueHistory.Dialogues.find(x => x.DialogueName == request.DialogueName);
         if (!dialogue) {
@@ -38,7 +36,6 @@ export const saveDialogueController: RequestHandler = async (req, res) => {
                         AvailableGiftDate: new Date(0),
                         RankUpExpiry: new Date(0),
                         BountyChemExpiry: new Date(0),
-                        QueuedDialogues: [],
                         Gifts: [],
                         Booleans: [],
                         Completed: [],
@@ -48,16 +45,9 @@ export const saveDialogueController: RequestHandler = async (req, res) => {
         }
         dialogue.Rank = request.Rank;
         dialogue.Chemistry = request.Chemistry;
-        dialogue.QueuedDialogues = request.QueuedDialogues;
+        //dialogue.QueuedDialogues = request.QueuedDialogues;
         for (const bool of request.Booleans) {
             dialogue.Booleans.push(bool);
-            if (bool == "LizzieShawzin") {
-                await addEmailItem(
-                    inventory,
-                    "/Lotus/Types/Items/EmailItems/LizzieShawzinSkinEmailItem",
-                    inventoryChanges
-                );
-            }
         }
         for (const bool of request.ResetBooleans) {
             const index = dialogue.Booleans.findIndex(x => x == bool);
@@ -70,7 +60,7 @@ export const saveDialogueController: RequestHandler = async (req, res) => {
         dialogue.AvailableDate = new Date(tomorrowAt0Utc);
         await inventory.save();
         res.json({
-            InventoryChanges: inventoryChanges,
+            InventoryChanges: [],
             AvailableDate: { $date: { $numberLong: tomorrowAt0Utc.toString() } }
         });
     }
@@ -87,7 +77,7 @@ interface SaveCompletedDialogueRequest {
     Rank: number;
     Chemistry: number;
     CompletionType: number;
-    QueuedDialogues: string[];
+    QueuedDialogues: string[]; // unsure
     Booleans: string[];
     ResetBooleans: string[];
     Data: ICompletedDialogue;

src/models/inventoryModels/inventoryModel.ts

@@ -773,7 +773,7 @@ const dialogueSchema = new Schema<IDialogueDatabase>(
         AvailableGiftDate: Date,
         RankUpExpiry: Date,
         BountyChemExpiry: Date,
-        QueuedDialogues: { type: [String], default: [] },
+        //QueuedDialogues: ???
         Gifts: { type: [dialogueGiftSchema], default: [] },
         Booleans: { type: [String], default: [] },
         Completed: { type: [completedDialogueSchema], default: [] },
@@ -797,7 +797,6 @@ dialogueSchema.set("toJSON", {
 const dialogueHistorySchema = new Schema<IDialogueHistoryDatabase>(
     {
         YearIteration: { type: Number, required: true },
-        Resets: Number,
         Dialogues: { type: [dialogueSchema], required: false }
     },
     { _id: false }

src/services/inventoryService.ts

@@ -1014,14 +1014,12 @@ export const addCustomization = (
     customizationName: string,
     inventoryChanges: IInventoryChanges = {}
 ): IInventoryChanges => {
-    if (!inventory.FlavourItems.find(x => x.ItemType == customizationName)) {
     const flavourItemIndex = inventory.FlavourItems.push({ ItemType: customizationName }) - 1;
     // eslint-disable-next-line @typescript-eslint/no-unnecessary-condition
     inventoryChanges.FlavourItems ??= [];
     (inventoryChanges.FlavourItems as IFlavourItem[]).push(
         inventory.FlavourItems[flavourItemIndex].toJSON<IFlavourItem>()
     );
-    }
     return inventoryChanges;
 };
 

src/services/missionInventoryUpdateService.ts

@@ -363,12 +363,12 @@ export const addMissionInventoryUpdates = async (
                 break;
             }
             case "DeathMarks": {
-                for (const deathMark of value) {
+                for (const bossName of value) {
-                    if (!inventory.DeathMarks.find(x => x == deathMark)) {
+                    if (inventory.DeathMarks.indexOf(bossName) == -1) {
                         // It's a new death mark; we have to say the line.
                         await createMessage(inventory.accountOwnerId, [
                             {
-                                sub: "/Lotus/Language/G1Quests/DeathMarkTitle",
+                                sub: bossName,
                                 sndr: "/Lotus/Language/G1Quests/DeathMarkSender",
                                 msg: "/Lotus/Language/G1Quests/DeathMarkMessage",
                                 icon: "/Lotus/Interface/Icons/Npcs/Stalker_d.png",

src/types/inventoryTypes/inventoryTypes.ts

@@ -1074,13 +1074,11 @@ export interface IEndlessXpProgress {
 
 export interface IDialogueHistoryClient {
     YearIteration: number;
-    Resets?: number; // added in 38.5.0
     Dialogues?: IDialogueClient[];
 }
 
 export interface IDialogueHistoryDatabase {
     YearIteration: number;
-    Resets?: number;
     Dialogues?: IDialogueDatabase[];
 }
 
@@ -1091,7 +1089,7 @@ export interface IDialogueClient {
     AvailableGiftDate: IMongoDate;
     RankUpExpiry: IMongoDate;
     BountyChemExpiry: IMongoDate;
-    QueuedDialogues: string[];
+    //QueuedDialogues: any[];
     Gifts: IDialogueGift[];
     Booleans: string[];
     Completed: ICompletedDialogue[];