From e46b3c7d29c9672a7e6d716bf0504863a8777ef1 Mon Sep 17 00:00:00 2001
From: Sainan <sainan@calamity.inc>
Date: Mon, 3 Feb 2025 13:20:56 -0800
Subject: [PATCH] chore: use mongoose's 'id' function in addGearExpByCategory
 (#892)

Reviewed-on: http://209.141.38.3/OpenWF/SpaceNinjaServer/pulls/892
---
 src/services/inventoryService.ts | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/src/services/inventoryService.ts b/src/services/inventoryService.ts
index 30c1acd4..a09ba252 100644
--- a/src/services/inventoryService.ts
+++ b/src/services/inventoryService.ts
@@ -823,12 +823,10 @@ export const addGearExpByCategory = (
             return;
         }
 
-        const itemIndex = ItemId ? category.findIndex(item => item._id?.equals(ItemId.$oid)) : -1;
-        if (itemIndex !== -1) {
-            const item = category[itemIndex];
+        const item = category.id(ItemId.$oid);
+        if (item) {
             item.XP ??= 0;
             item.XP += XP;
-            inventory.markModified(`${categoryName}.${itemIndex}.XP`);
 
             const xpinfoIndex = inventory.XPInfo.findIndex(x => x.ItemType == item.ItemType);
             if (xpinfoIndex !== -1) {