From d94b4fd946203e97554e310c4f14dbac8346417c Mon Sep 17 00:00:00 2001
From: Sainan <63328889+Sainan@users.noreply.github.com>
Date: Fri, 4 Apr 2025 15:16:57 -0700
Subject: [PATCH] chore: use parallelForeach in deleteGuild (#1458)

Reviewed-on: https://onlyg.it/OpenWF/SpaceNinjaServer/pulls/1458
Co-authored-by: Sainan <63328889+Sainan@users.noreply.github.com>
Co-committed-by: Sainan <63328889+Sainan@users.noreply.github.com>
---
 src/services/guildService.ts | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/src/services/guildService.ts b/src/services/guildService.ts
index 0e05bb94..532496aa 100644
--- a/src/services/guildService.ts
+++ b/src/services/guildService.ts
@@ -29,6 +29,7 @@ import { getRandomInt } from "./rngService";
 import { Inbox } from "../models/inboxModel";
 import { IFusionTreasure, ITypeCount } from "../types/inventoryTypes/inventoryTypes";
 import { IInventoryChanges } from "../types/purchaseTypes";
+import { parallelForeach } from "../utils/async-utils";
 
 export const getGuildForRequest = async (req: Request): Promise<TGuildDatabaseDocument> => {
     const accountId = await getAccountIdForRequest(req);
@@ -595,12 +596,12 @@ export const deleteGuild = async (guildId: Types.ObjectId): Promise<void> => {
     await Guild.deleteOne({ _id: guildId });
 
     const guildMembers = await GuildMember.find({ guildId, status: 0 }, "accountId");
-    for (const member of guildMembers) {
+    await parallelForeach(guildMembers, async member => {
         const inventory = await getInventory(member.accountId.toString(), "GuildId LevelKeys Recipes");
         inventory.GuildId = undefined;
         removeDojoKeyItems(inventory);
         await inventory.save();
-    }
+    });
 
     await GuildMember.deleteMany({ guildId });