From a622393933c8f99d5fa7602b3fdc95c54680d8fb Mon Sep 17 00:00:00 2001
From: Sainan <sainan@calamity.inc>
Date: Thu, 27 Mar 2025 03:33:27 -0700
Subject: [PATCH] chore: don't validate Nonce in query (#1341)

By asking MongoDB to simply find the account by the ID and then validating the nonce ourselves, we save roughly 1ms.

Reviewed-on: https://onlyg.it/OpenWF/SpaceNinjaServer/pulls/1341
---
 src/services/loginService.ts | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/src/services/loginService.ts b/src/services/loginService.ts
index c69e891d..77ffc95c 100644
--- a/src/services/loginService.ts
+++ b/src/services/loginService.ts
@@ -74,11 +74,8 @@ export const getAccountForRequest = async (req: Request): Promise<TAccountDocume
         throw new Error("Request is missing nonce parameter");
     }
 
-    const account = await Account.findOne({
-        _id: req.query.accountId,
-        Nonce: nonce
-    });
-    if (!account) {
+    const account = await Account.findById(req.query.accountId);
+    if (!account || account.Nonce != nonce) {
         throw new Error("Invalid accountId-nonce pair");
     }
     if (account.Dropped && req.query.ct) {