From 93afc2645c4c57cfa859c1997bb99550cfd5e5c5 Mon Sep 17 00:00:00 2001 From: Sainan Date: Tue, 25 Feb 2025 04:42:49 -0800 Subject: [PATCH] fix: items from enemy caches not showing "identified" (#1016) Reviewed-on: https://onlyg.it/OpenWF/SpaceNinjaServer/pulls/1016 Co-authored-by: Sainan Co-committed-by: Sainan --- src/services/missionInventoryUpdateService.ts | 14 ++++++-------- src/types/missionTypes.ts | 2 ++ 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/src/services/missionInventoryUpdateService.ts b/src/services/missionInventoryUpdateService.ts index b4e9c41f..d0e82376 100644 --- a/src/services/missionInventoryUpdateService.ts +++ b/src/services/missionInventoryUpdateService.ts @@ -233,9 +233,7 @@ export const addMissionRewards = async ( } //TODO: check double reward merging - const MissionRewards = getRandomMissionDrops(rewardInfo).map(drop => { - return { StoreItem: drop.type, ItemCount: drop.itemCount }; - }); + const MissionRewards: IMissionReward[] = getRandomMissionDrops(rewardInfo); logger.debug("random mission drops:", MissionRewards); const inventoryChanges: IInventoryChanges = {}; @@ -382,8 +380,8 @@ function getLevelCreditRewards(nodeName: string): number { //TODO: get dark sektor fixed credit rewards and railjack bonus } -function getRandomMissionDrops(RewardInfo: IRewardInfo): IRngResult[] { - const drops: IRngResult[] = []; +function getRandomMissionDrops(RewardInfo: IRewardInfo): IMissionReward[] { + const drops: IMissionReward[] = []; if (RewardInfo.node in ExportRegions) { const region = ExportRegions[RewardInfo.node]; const rewardManifests: string[] = @@ -408,7 +406,7 @@ function getRandomMissionDrops(RewardInfo: IRewardInfo): IRngResult[] { const rotationRewards = table[rotation]; const drop = getRandomRewardByChance(rotationRewards); if (drop) { - drops.push(drop); + drops.push({ StoreItem: drop.type, ItemCount: drop.itemCount }); } } }); @@ -418,7 +416,7 @@ function getRandomMissionDrops(RewardInfo: IRewardInfo): IRngResult[] { for (let rotation = 0; rotation != RewardInfo.EnemyCachesFound; ++rotation) { const drop = getRandomRewardByChance(deck[rotation]); if (drop) { - drops.push(drop); + drops.push({ StoreItem: drop.type, ItemCount: drop.itemCount, FromEnemyCache: true }); } } } @@ -437,7 +435,7 @@ function getRandomMissionDrops(RewardInfo: IRewardInfo): IRngResult[] { const drop = getRandomRewardByChance(deck[rotation]); if (drop) { - drops.push(drop); + drops.push({ StoreItem: drop.type, ItemCount: drop.itemCount }); } } } diff --git a/src/types/missionTypes.ts b/src/types/missionTypes.ts index 8e79e8d8..c8cab373 100644 --- a/src/types/missionTypes.ts +++ b/src/types/missionTypes.ts @@ -8,4 +8,6 @@ export interface IMissionReward { ItemCount: number; TweetText?: string; ProductCategory?: string; + FromEnemyCache?: boolean; + IsStrippedItem?: boolean; }